Possible bug in MIMXRT1060_EVKB Devicetree, sai1 node

[herculanodavi]

As written in the issues template, I am first verifying that the issue is a genuine Zephyr bug before making an issue.

Describe the bug
Hi, I am checking the SAI NXP driver usage with MIMXRT1060_EVKB, and I see the implementation of the function enable_mclk_direction will the GPR1 field of the IOMUXC_GPR by adding base and offset, and will set/unset the MCLK output with the mask.
For the case of MIMXRT1060_EVK, we have that for the sa1 node, pinmuxes = <&iomuxcgpr 0x4 0x80000>;. The function mentioned in the start will apparently do the same as IOMUXC_EnableMode of MCUx, which uses the GPR1 register directly from the definition instead of using the offset/mask pair.

Looking at the implementation:

static void enable_mclk_direction(const struct device *dev, bool dir)
{
	const struct i2s_mcux_config *dev_cfg = dev->config;
	uint32_t offset = dev_cfg->mclk_pin_offset;
	uint32_t mask = dev_cfg->mclk_pin_mask;
	uint32_t *base = (uint32_t *)(dev_cfg->mclk_control_base + offset);

	if (dir) {
		*base |= mask;
	} else {
		*base &= ~mask;
	}
}

And IOMUXC_EnableMode accesses GPR1 by the definition below:

/** IOMUXC_GPR - Register Layout Typedef */
typedef struct {
       uint32_t GPR0;                              /**< GPR0 General Purpose Register, offset: 0x0 */
  __IO uint32_t GPR1;                              /**< GPR1 General Purpose Register, offset: 0x4 */
  /* ...up to GPR34 */
} IOMUXC_GPR_Type;

The offset in the line uint32_t *base = (uint32_t *)(dev_cfg->mclk_control_base + offset); will add offset words to the base. The dts property adds 0x4 words, when it should be 4 bytes (one word). The consequence is that MCLK is not activated. Should the dts definition be changed to pinmuxes = <&iomuxcgpr 0x1 0x80000>;? This change makes the MCLK of my board activate.

Expected behavior
To configure my SAI driver and to see a MCLK signal in my logic analyzer.

Impact
The onboard codec of MIMXRT1060_EVKB doesn't work with default definitions of sai1.

Logs and console output
No difference in logs is shown. The current version with 0x4 has no MCLK signal and the one with an overlay with pinmuxes = <&iomuxcgpr 0x1 0x80000>; has MCLK signal.

Environment (please complete the following information):

• OS: Windows WSL
• Toolchain Zephyr master
• SHA: ee05087

[Raymond0225]

Thank you for your detail information. I am working to prepare a patch for this bug.

[Raymond0225]

#83978