SOC DTS using symbols for addesses and irqs

[jcpince]

Hi,

I'm working on a new SOC port on Zephyr.

When writing the DTS soc file, I was considering using SOC symbols instead of raw addresses and irqs to avoid mistakes and misalignment with soc generated headers.

For my platform as for many, the soc headers are provided by the design team, generated and shared with customers and other platforms; so they are the reference (entry point) used across all the platform code.

During an internal code review, I got a comment saying that it's not Zephyr's way and should not be used. Our plan would be to share our port so I'm wondering if this could be up streamed or if we will have to change to the raw addresses declaration...

For example, with the following soc header:

// MYSOC.H -- GENERATED -- DO NOT TOUCH!!!
#define SPI_M_REG_BASE_ADDRESS 4100C000
#define SPI_M_REG_BASE_ADDRESS_HEX 0x4100C000
#define SPI_M_REG_RANGE 0x100

#define DT_REG_BASE(__name__)  __name__##_REG_BASE_ADDRESS
#define DT_REG_SPACE(__name__) __name__##_REG_BASE_ADDRESS_HEX __name__##_REG_RANGE

Then, I would replace:

		spim: spi@4100C000 {
			compatible = "mycomp,chip-spim";
			reg = <0x4100C000 0x100>;
			#address-cells = <1>;
			#size-cells = <0>;
			interrupts = <43 2>;
			interrupt-parent = <&nvic>;
			status = "disabled";
		};

with:

		spim: spi@DT_REG_BASE(SPI_M) {
			compatible = "mycomp,chip-spim";
			reg = <DT_REG_SPACE(SPI_M)>;
			#address-cells = <1>;
			#size-cells = <0>;
			interrupts = <SPI_M_IRQn DEFAULT_IRQ_PRIO>;
			interrupt-parent = <&nvic>;
			status = "disabled";
		};

using the soc generated symbols...