Help: Stuck on getting driver binding

[mcscholtz]

I am having some issues using a driver and I don't know what I am doing wrong.

The driver in question (drivers/eeprom/eeprom_at2x.c) is defined like this:

        #define INST_DT_AT2X(inst, t) DT_INST(inst, atmel_at##t)
        ...
        static struct eeprom_at2x_data eeprom_at##t##_data_##n;                                    \
	DEVICE_DT_DEFINE(INST_DT_AT2X(n, t), &eeprom_at2x_init, NULL, &eeprom_at##t##_data_##n,    \
			 &eeprom_at##t##_config_##n, POST_KERNEL,                                  \
			 CONFIG_EEPROM_AT2X_INIT_PRIORITY, &eeprom_at2x_api)

The associated device tree for my board is as follows:

&i2c1 {
	// EEPROM IO
	pinctrl-0 = <&i2c1_scl_pb6 &i2c1_sda_pb9>;
	clock-frequency = <I2C_BITRATE_FAST>;
	status = "okay";

	i2c_eeprom: eeprom@50 {
		compatible = "atmel,at2x";
		reg = <0x50>;
		label = "eeprom";
		wp-gpio = <&gpiob 7 GPIO_ACTIVE_LOW>;
		size = <DT_SIZE_M(2)>;
		pagesize = <256>;
		address-width = <16>;
		timeout = <10>;
		status = "okay";
	};
};

This driver can take 2 variants at24 and at25. I am using at24 so I tried the following:

const struct device *dev = DEVICE_DT_GET_ANY(atmel_at24);

This compiles okay but the returned pointer is always NULL

I also tried this:

#define EEPROM1_NODE DT_NODELABEL(i2c_eeprom)

#if !DT_NODE_HAS_COMPAT(EEPROM1_NODE, atmel_at2x)
#error "EEPROM is not enabled"
#endif
....
const struct device *dev = DEVICE_DT_GET(EEPROM1_NODE);

This gives me the following linking error:

[3/9] Linking C executable zephyr/zephyr_prebuilt.elf
FAILED: zephyr/zephyr_prebuilt.elf zephyr/zephyr_prebuilt.map 
: && ccache /home/mariuss/zephyr-sdk-0.12.4/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc    zephyr/CMakeFiles/zephyr_prebuilt.dir/misc/empty_file.c.obj  -o zephyr/zephyr_prebuilt.elf  -fuse-ld=bfd  -Wl,-T  zephyr/linker_zephyr_prebuilt.cmd  -Wl,-Map=/home/mariuss/Documents/projects/BMS/app/build/zephyr/zephyr_prebuilt.map  -Wl,--whole-archive  app/libapp.a  zephyr/libzephyr.a  zephyr/arch/common/libarch__common.a  zephyr/arch/arch/arm/core/aarch32/libarch__arm__core__aarch32.a  zephyr/arch/arch/arm/core/aarch32/cortex_m/libarch__arm__core__aarch32__cortex_m.a  zephyr/arch/arch/arm/core/aarch32/mpu/libarch__arm__core__aarch32__mpu.a  zephyr/lib/libc/minimal/liblib__libc__minimal.a  zephyr/lib/posix/liblib__posix.a  zephyr/soc/arm/common/cortex_m/libsoc__arm__common__cortex_m.a  zephyr/drivers/adc/libdrivers__adc.a  zephyr/drivers/gpio/libdrivers__gpio.a  zephyr/drivers/i2c/libdrivers__i2c.a  zephyr/drivers/eeprom/libdrivers__eeprom.a  zephyr/drivers/serial/libdrivers__serial.a  modules/stm32/stm32cube/lib..__modules__hal__stm32__stm32cube.a  -Wl,--no-whole-archive  zephyr/kernel/libkernel.a  zephyr/CMakeFiles/offsets.dir/arch/arm/core/offsets/offsets.c.obj  -L"/home/mariuss/zephyr-sdk-0.12.4/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/10.2.0/thumb/v7e-m/nofp"  -L/home/mariuss/Documents/projects/BMS/app/build/zephyr  -lgcc  zephyr/arch/common/libisr_tables.a  -mcpu=cortex-m4  -mthumb  -mabi=aapcs  -Wl,--gc-sections  -Wl,--build-id=none  -Wl,--sort-common=descending  -Wl,--sort-section=alignment  -Wl,-u,_OffsetAbsSyms  -Wl,-u,_ConfigAbsSyms  -nostdlib  -static  -no-pie  -Wl,-X  -Wl,-N  -Wl,--orphan-handling=warn && cd /home/mariuss/Documents/projects/BMS/app/build/zephyr && /usr/bin/cmake -E echo
/home/mariuss/zephyr-sdk-0.12.4/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/10.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd: app/libapp.a(main.c.obj): in function `main':
/home/mariuss/Documents/projects/BMS/app/build/../src/main.c:189: undefined reference to `__device_dts_ord_100'
collect2: error: ld returned 1 exit status

Looks like some of the generated code is not right, presumably I am using the wrong macro to get the device binding?

I also tried the following:

const struct device *dev = device_get_binding("eeprom");
const struct device *dev = device_get_binding("eeprom_50");
const struct device *dev = device_get_binding("eeprom@50");
const struct device *dev = device_get_binding("i2c_eeprom");

None of which worked.

Is this a bug or am I just doing things wrong? Any help will be appreciated.

[mcscholtz]

I found the problem. I had to make the following change to the device tree:

&i2c1 {
	// EEPROM IO
	pinctrl-0 = <&i2c1_scl_pb6 &i2c1_sda_pb9>;
	clock-frequency = <I2C_BITRATE_FAST>;
	status = "okay";

	i2c_eeprom: eeprom@50 {
		compatible = "atmel,at24";                                  //atmel,at24 not atmel,at2x
		reg = <0x50>;
		label = "eeprom";
		wp-gpios = <&gpiob 7 GPIO_ACTIVE_LOW>;    //wp-gpios not wp-gpio
		size = <DT_SIZE_M(2)>;
		pagesize = <256>;
		address-width = <16>;
		timeout = <10>;
		status = "okay";
	};
};

After that I could get the driver with:

DEVICE_DT_GET_ANY(atmel_at24);