Skip to content

Commit e306902

Browse files
author
Alain Volmat
committed
video: common: addition of MENU_INTEGER control type
Add a new MENU_INTEGER type allowing to store signed 64bits integer into a menu. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
1 parent f372b70 commit e306902

File tree

3 files changed

+51
-5
lines changed

3 files changed

+51
-5
lines changed

drivers/video/video_ctrls.c

Lines changed: 37 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ static inline int check_range(enum video_ctrl_type type, struct video_ctrl_range
7070
}
7171
return 0;
7272
case VIDEO_CTRL_TYPE_MENU:
73+
case VIDEO_CTRL_TYPE_MENU_INTEGER:
7374
if (!IN_RANGE(range.min, 0, range.max) ||
7475
!IN_RANGE(range.def, range.min, range.max)) {
7576
return -ERANGE;
@@ -196,6 +197,28 @@ int video_init_menu_ctrl(struct video_ctrl *ctrl, const struct device *dev, uint
196197
return 0;
197198
}
198199

200+
int video_init_int_menu_ctrl(struct video_ctrl *ctrl, const struct device *dev, uint32_t id,
201+
uint8_t def, const int64_t menu[], size_t menu_len)
202+
{
203+
int ret;
204+
205+
if (!menu) {
206+
return -EINVAL;
207+
}
208+
209+
ret = video_init_ctrl(
210+
ctrl, dev, id,
211+
(struct video_ctrl_range){.min = 0, .max = menu_len - 1, .step = 1, .def = def});
212+
213+
if (ret) {
214+
return ret;
215+
}
216+
217+
ctrl->int_menu = menu;
218+
219+
return 0;
220+
}
221+
199222
/* By definition, the cluster is in manual mode if the master control value is 0 */
200223
static inline bool is_cluster_manual(const struct video_ctrl *master)
201224
{
@@ -540,7 +563,11 @@ int video_query_ctrl(const struct device *dev, struct video_ctrl_query *cq)
540563
cq->type = ctrl->type;
541564
cq->flags = ctrl->flags;
542565
cq->range = ctrl->range;
543-
cq->menu = ctrl->menu;
566+
if (cq->type == VIDEO_CTRL_TYPE_MENU) {
567+
cq->menu = ctrl->menu;
568+
} else if (cq->type == VIDEO_CTRL_TYPE_MENU_INTEGER) {
569+
cq->int_menu = ctrl->int_menu;
570+
}
544571
cq->name = video_get_ctrl_name(cq->id);
545572

546573
return 0;
@@ -568,6 +595,9 @@ void video_print_ctrl(const struct device *const dev, const struct video_ctrl_qu
568595
case VIDEO_CTRL_TYPE_MENU:
569596
type = "menu";
570597
break;
598+
case VIDEO_CTRL_TYPE_MENU_INTEGER:
599+
type = "menu integer";
600+
break;
571601
case VIDEO_CTRL_TYPE_STRING:
572602
type = "string";
573603
break;
@@ -594,10 +624,15 @@ void video_print_ctrl(const struct device *const dev, const struct video_ctrl_qu
594624
cq->range.step, cq->range.def, vc.val);
595625
}
596626

597-
if (cq->menu) {
627+
if (cq->type == VIDEO_CTRL_TYPE_MENU && cq->menu) {
598628
while (cq->menu[i]) {
599629
LOG_INF("%*s %u: %s", 32, "", i, cq->menu[i]);
600630
i++;
601631
}
632+
} else if (cq->type == VIDEO_CTRL_TYPE_MENU_INTEGER && cq->int_menu) {
633+
while (cq->int_menu[i]) {
634+
LOG_INF("%*s %u: %lld", 12, "", i, cq->int_menu[i]);
635+
i++;
636+
}
602637
}
603638
}

drivers/video/video_ctrls.h

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,12 @@ enum video_ctrl_type {
2727
VIDEO_CTRL_TYPE_INTEGER = 2,
2828
/** 64-bit integer type */
2929
VIDEO_CTRL_TYPE_INTEGER64 = 3,
30-
/** Menu type, standard or driver-defined menu */
30+
/** Menu string type, standard or driver-defined menu */
3131
VIDEO_CTRL_TYPE_MENU = 4,
3232
/** String type */
3333
VIDEO_CTRL_TYPE_STRING = 5,
34+
/** Menu integer type, standard or driver-defined menu */
35+
VIDEO_CTRL_TYPE_MENU_INTEGER = 6,
3436
};
3537

3638
struct video_device;
@@ -54,7 +56,10 @@ struct video_ctrl {
5456
int32_t val;
5557
int64_t val64;
5658
};
57-
const char *const *menu;
59+
union {
60+
const char *const *menu;
61+
const int64_t *int_menu;
62+
};
5863
sys_dnode_t node;
5964
};
6065

@@ -64,6 +69,9 @@ int video_init_ctrl(struct video_ctrl *ctrl, const struct device *dev, uint32_t
6469
int video_init_menu_ctrl(struct video_ctrl *ctrl, const struct device *dev, uint32_t id,
6570
uint8_t def, const char *const menu[]);
6671

72+
int video_init_int_menu_ctrl(struct video_ctrl *ctrl, const struct device *dev, uint32_t id,
73+
uint8_t def, const int64_t menu[], size_t menu_len);
74+
6775
void video_cluster_ctrl(struct video_ctrl *ctrls, uint8_t sz);
6876

6977
void video_auto_cluster_ctrl(struct video_ctrl *ctrls, uint8_t sz, bool set_volatile);

include/zephyr/drivers/video-controls.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,10 @@ struct video_ctrl_query {
463463
/** control range */
464464
struct video_ctrl_range range;
465465
/** menu if control is of menu type */
466-
const char *const *menu;
466+
union {
467+
const char *const *menu;
468+
const int64_t *int_menu;
469+
};
467470
};
468471

469472
/**

0 commit comments

Comments
 (0)