Skip to content

Commit e1f5783

Browse files
decsnykartben
authored andcommitted
dts: i2s_mcux_sai: Clarify IOMUXC GPR binding
Improve the documentation of the IOMUXC GPR binding so that it is clear what the cells in the specifier space of "pinmux" space mean. And change the names of the cells to be more appropriate. "offset" instead of "pin" and "mask" instead of "function" describes more precisely what the cells in the specifier mean. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
1 parent f40f58c commit e1f5783

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

drivers/i2s/i2s_mcux_sai.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,8 +1153,8 @@ static DEVICE_API(i2s, i2s_mcux_driver_api) = {
11531153
.pll_num = DT_PHA_BY_NAME_OR(DT_DRV_INST(i2s_id), pll_clocks, num, value, 0), \
11541154
.pll_den = DT_PHA_BY_NAME_OR(DT_DRV_INST(i2s_id), pll_clocks, den, value, 0), \
11551155
.mclk_control_base = DT_REG_ADDR(DT_PHANDLE(DT_DRV_INST(i2s_id), pinmuxes)), \
1156-
.mclk_pin_mask = DT_PHA_BY_IDX(DT_DRV_INST(i2s_id), pinmuxes, 0, function), \
1157-
.mclk_pin_offset = DT_PHA_BY_IDX(DT_DRV_INST(i2s_id), pinmuxes, 0, pin), \
1156+
.mclk_pin_mask = DT_PHA_BY_IDX(DT_DRV_INST(i2s_id), pinmuxes, 0, mask), \
1157+
.mclk_pin_offset = DT_PHA_BY_IDX(DT_DRV_INST(i2s_id), pinmuxes, 0, offset), \
11581158
.clk_sub_sys = \
11591159
(clock_control_subsys_t)DT_INST_CLOCKS_CELL_BY_IDX(i2s_id, 0, name), \
11601160
.ccm_dev = DEVICE_DT_GET(DT_INST_CLOCKS_CTLR(i2s_id)), \

dts/bindings/pinctrl/nxp,imx-gpr.yaml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
# Copyright (c) 2021, NXP
22
# SPDX-License-Identifier: Apache-2.0
33

4-
description: i.MX IOMUXC node
4+
description: |
5+
i.MX IOMUXC node
6+
7+
The specifier space "pinmux" of this binding should have two cells describing
8+
the resources needed from the GPR registers.
9+
For each specifier, the first cell should be the offset of the GPR register in bytes
10+
from the base address of the GPR device base address. The second cell should be a
11+
bitmask indicating which bits in the specified register are relevant to the referencing device.
512
613
compatible: "nxp,imx-gpr"
714

@@ -12,5 +19,5 @@ properties:
1219
required: true
1320

1421
pinmux-cells:
15-
- pin
16-
- function
22+
- offset
23+
- mask

0 commit comments

Comments
 (0)