drivers: wifi: siwx91x: Handle error case in power save mode

ArunmaniAlagarsamy2710 · kartben · commit de6395d5d0ea · 2025-06-04T17:04:24.000+02:00
Power save is not supported in AP mode. This commit ensures that
`-EINVAL` is returned instead of success, preventing incorrect behavior.

Signed-off-by: Arunmani Alagarsamy &lt;arunmani.a@silabs.com&gt;
diff --git a/drivers/wifi/siwx91x/siwx91x_wifi.c b/drivers/wifi/siwx91x/siwx91x_wifi.c
@@ -282,11 +282,13 @@ static int siwx91x_apply_power_save(struct siwx91x_dev *sidev)
 
 	interface = sl_wifi_get_default_interface();
 	if (FIELD_GET(SIWX91X_INTERFACE_MASK, interface) != SL_WIFI_CLIENT_INTERFACE) {
-		return 0;
+		LOG_ERR("Wi-Fi not in station mode");
+		return -EINVAL;
 	}
 
 	if (sidev->state == WIFI_STATE_INTERFACE_DISABLED) {
-		return 0;
+		LOG_ERR("Command given in invalid state");
+		return -EINVAL;
 	}
 
 	sl_wifi_get_performance_profile(&sl_ps_profile);

Original file line number	Diff line number	Diff line change
`@@ -282,11 +282,13 @@ static int siwx91x_apply_power_save(struct siwx91x_dev *sidev)`
`282`	`282`
`283`	`283`	`interface = sl_wifi_get_default_interface();`
`284`	`284`	`if (FIELD_GET(SIWX91X_INTERFACE_MASK, interface) != SL_WIFI_CLIENT_INTERFACE) {`
`285`		`- return 0;`
	`285`	`+ LOG_ERR("Wi-Fi not in station mode");`
	`286`	`+ return -EINVAL;`
`286`	`287`	`}`
`287`	`288`
`288`	`289`	`if (sidev->state == WIFI_STATE_INTERFACE_DISABLED) {`
`289`		`- return 0;`
	`290`	`+ LOG_ERR("Command given in invalid state");`
	`291`	`+ return -EINVAL;`
`290`	`292`	`}`
`291`	`293`
`292`	`294`	`sl_wifi_get_performance_profile(&sl_ps_profile);`