drivers: ethernet: nxp_imx_netc_psi: move net_if_carrier_off()

maass-hamburg · kartben · commit ddfb3909f65c · 2025-04-23T10:03:55.000+02:00
move net_if_carrier_off() before
phy_link_callback_set() to ensure the carrier is
not truned off, when the link is already up.

Signed-off-by: Fin Maaß &lt;f.maass@vogl-electronic.com&gt;
diff --git a/drivers/ethernet/nxp_imx_netc/eth_nxp_imx_netc_psi.c b/drivers/ethernet/nxp_imx_netc/eth_nxp_imx_netc_psi.c
@@ -93,10 +93,10 @@ static void netc_eth_iface_init(struct net_if *iface)
 		LOG_ERR("PHY device (%p) is not ready, cannot init iface", cfg->phy_dev);
 		return;
 	}
-	phy_link_callback_set(cfg->phy_dev, &netc_eth_phylink_callback, (void *)dev);
-
 	/* Do not start the interface until PHY link is up */
 	net_if_carrier_off(iface);
+
+	phy_link_callback_set(cfg->phy_dev, &netc_eth_phylink_callback, (void *)dev);
 }
 
 static int netc_eth_init(const struct device *dev)

Original file line number	Diff line number	Diff line change
`@@ -93,10 +93,10 @@ static void netc_eth_iface_init(struct net_if *iface)`
`93`	`93`	`LOG_ERR("PHY device (%p) is not ready, cannot init iface", cfg->phy_dev);`
`94`	`94`	`return;`
`95`	`95`	`}`
`96`		`- phy_link_callback_set(cfg->phy_dev, &netc_eth_phylink_callback, (void *)dev);`
`97`		`-`
`98`	`96`	`/* Do not start the interface until PHY link is up */`
`99`	`97`	`net_if_carrier_off(iface);`
	`98`	`+`
	`99`	`+ phy_link_callback_set(cfg->phy_dev, &netc_eth_phylink_callback, (void *)dev);`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`static int netc_eth_init(const struct device *dev)`