drivers: ethernet: phy: microchip_vsc8541: use mutex

use mutex to protect page register

phy_mc_vsc8541_get_link got removed from
phy_mc_vsc8541_link_cb_set so, that
phy_mc_vsc8541_link_monitor (own thread)
is the only one to change data->state

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>

Author: maass-hamburg

drivers/ethernet/phy/phy_microchip_vsc8541.c

@@ -291,6 +291,8 @@ static int phy_mc_vsc8541_init(const struct device *dev)
 
 	data->active_page = -1;
 
+	k_mutex_init(&data->mutex);
+
 	/* Reset PHY */
 	ret = phy_mc_vsc8541_reset(dev);
 	if (ret < 0) {
@@ -370,8 +372,6 @@ static int phy_mc_vsc8541_link_cb_set(const struct device *dev, phy_callback_t c
 	data->cb = cb;
 	data->cb_data = user_data;
 
-	phy_mc_vsc8541_get_link(dev, &data->state);
-
 	data->cb(dev, &data->state, data->cb_data);
 
 	return 0;
@@ -431,22 +431,24 @@ static int phy_mc_vsc8541_read(const struct device *dev, uint16_t reg_addr, uint
 	/* mask out lower byte */
 	reg_addr &= 0x00ff;
 
+	k_mutex_lock(&dev_data->mutex, K_FOREVER);
+
 	/* select page, given by register upper byte */
 	if (dev_data->active_page != page) {
 		ret = mdio_write(cfg->mdio_dev, cfg->addr, PHY_REG_PAGE_SELECTOR, (uint16_t)page);
-		if (ret) {
-			return ret;
+		if (ret < 0) {
+			goto read_end;
 		}
 		dev_data->active_page = (int)page;
 	}
 
 	/* select register, given by register lower byte */
 	ret = mdio_read(cfg->mdio_dev, cfg->addr, reg_addr, (uint16_t *)data);
-	if (ret) {
-		return ret;
-	}
 
-	return 0;
+read_end:
+	k_mutex_unlock(&dev_data->mutex);
+
+	return ret;
 }
 
 /**
@@ -469,22 +471,24 @@ static int phy_mc_vsc8541_write(const struct device *dev, uint16_t reg_addr, uin
 	/* mask out lower byte */
 	reg_addr &= 0x00ff;
 
+	k_mutex_lock(&dev_data->mutex, K_FOREVER);
+
 	/* select page, given by register upper byte */
 	if (dev_data->active_page != page) {
 		ret = mdio_write(cfg->mdio_dev, cfg->addr, PHY_REG_PAGE_SELECTOR, (uint16_t)page);
-		if (ret) {
-			return ret;
+		if (ret < 0) {
+			goto write_end;
 		}
 		dev_data->active_page = (int)page;
 	}
 
 	/* write register, given by lower byte */
 	ret = mdio_write(cfg->mdio_dev, cfg->addr, reg_addr, (uint16_t)data);
-	if (ret) {
-		return ret;
-	}
 
-	return 0;
+write_end:
+	k_mutex_unlock(&dev_data->mutex);
+
+	return ret;
 }
 
 static DEVICE_API(ethphy, mc_vsc8541_phy_api) = {