drivers: video: ov5640: Fix constrast value sign

trunghieulenxp · kartben · commit da1213552583 · 2025-05-20T18:27:35.000+02:00
Fix sign's register for constrast value.

Signed-off-by: Trung Hieu Le &lt;trunghieu.le@nxp.com&gt;
Signed-off-by: Phi Bang Nguyen &lt;phibang.nguyen@nxp.com&gt;
diff --git a/drivers/video/ov5640.c b/drivers/video/ov5640.c
@@ -1045,6 +1045,11 @@ static int ov5640_set_ctrl_contrast(const struct device *dev, int value)
 		return ret;
 	}
 
+	ret = ov5640_modify_reg(&cfg->i2c, SDE_CTRL6_REG, BIT(2), value >= 0 ? 0 : BIT(2));
+	if (ret < 0) {
+		return ret;
+	}
+
 	return ov5640_write_reg(&cfg->i2c, SDE_CTRL6_REG, value & 0xff);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1045,6 +1045,11 @@ static int ov5640_set_ctrl_contrast(const struct device *dev, int value)`
`1045`	`1045`	`return ret;`
`1046`	`1046`	`}`
`1047`	`1047`
	`1048`	`+ ret = ov5640_modify_reg(&cfg->i2c, SDE_CTRL6_REG, BIT(2), value >= 0 ? 0 : BIT(2));`
	`1049`	`+ if (ret < 0) {`
	`1050`	`+ return ret;`
	`1051`	`+ }`
	`1052`	`+`
`1048`	`1053`	`return ov5640_write_reg(&cfg->i2c, SDE_CTRL6_REG, value & 0xff);`
`1049`	`1054`	`}`
`1050`	`1055`