modules: hostap: hapd_events: Fix possible null deference

moonlight83340 · danieldegrasse · commit cd855104f24d · 2025-07-11T16:32:57.000-05:00
Move usage of ap_ctx pointers after null checks to prevent potential
crashes.

Signed-off-by: Gaetan Perrot &lt;gaetan.perrot@spacecubics.com&gt;
diff --git a/modules/hostap/src/hapd_events.c b/modules/hostap/src/hapd_events.c
@@ -69,13 +69,15 @@ int hostapd_send_wifi_mgmt_ap_sta_event(struct hostapd_iface *ap_ctx,
 					void *data)
 {
 	struct sta_info *sta = data;
-	char *ifname = ap_ctx->bss[0]->conf->iface;
+	char *ifname;
 	struct wifi_ap_sta_info sta_info = { 0 };
 
 	if (!ap_ctx || !sta) {
 		return -EINVAL;
 	}
 
+	ifname = ap_ctx->bss[0]->conf->iface;
+
 	memcpy(sta_info.mac, sta->addr, sizeof(sta_info.mac));
 
 	if (event == NET_EVENT_WIFI_CMD_AP_STA_CONNECTED) {

Original file line number	Diff line number	Diff line change
`@@ -69,13 +69,15 @@ int hostapd_send_wifi_mgmt_ap_sta_event(struct hostapd_iface *ap_ctx,`
`69`	`69`	`void *data)`
`70`	`70`	`{`
`71`	`71`	`struct sta_info *sta = data;`
`72`		`- char *ifname = ap_ctx->bss[0]->conf->iface;`
	`72`	`+ char *ifname;`
`73`	`73`	`struct wifi_ap_sta_info sta_info = { 0 };`
`74`	`74`
`75`	`75`	`if (!ap_ctx \|\| !sta) {`
`76`	`76`	`return -EINVAL;`
`77`	`77`	`}`
`78`	`78`
	`79`	`+ ifname = ap_ctx->bss[0]->conf->iface;`
	`80`	`+`
`79`	`81`	`memcpy(sta_info.mac, sta->addr, sizeof(sta_info.mac));`
`80`	`82`
`81`	`83`	`if (event == NET_EVENT_WIFI_CMD_AP_STA_CONNECTED) {`