Skip to content

Commit c8c0c29

Browse files
mathieuchopstmnashif
authored andcommitted
arch: arm: cortex_a_r: use correct name for TLB Conflict Abort
Commit 8771982 introduced FSR definitions for ARMv7-A/R; however, the value 16 which is documented in the ARM[1] as a "TLB Conflict Abort", was introduced as "TLB Conflict Fault" instead and described as a "Table Conflict Fault". Update all affected files to use the ARM's naming for this error instead. [1] Architecture Reference Manual (Document ID: ARM DDI 0406C.d) "ARM Architecture Reference Manual for ARMv7-A and ARMv7-R Edition" Signed-off-by: Mathieu Choplain <mathieu.choplain@st.com>
1 parent 5ab74ff commit c8c0c29

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

arch/arm/core/cortex_a_r/fault.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,9 @@ static uint32_t dump_fault(uint32_t status, uint32_t addr)
141141
reason = K_ERR_ARM_SYNC_EXTERNAL_ABORT_TRANSLATION_TABLE_2ND_LEVEL;
142142
LOG_ERR("2nd Level Synchronous External Abort Translation Table @ 0x%08x", addr);
143143
break;
144-
case FSR_FS_TLB_CONFLICT_FAULT:
145-
reason = K_ERR_ARM_TLB_CONFLICT_FAULT;
146-
LOG_ERR("Table Conflict Fault @ 0x%08x", addr);
144+
case FSR_FS_TLB_CONFLICT_ABORT:
145+
reason = K_ERR_ARM_TLB_CONFLICT_ABORT;
146+
LOG_ERR("TLB Conflict Abort @ 0x%08x", addr);
147147
break;
148148
case FSR_FS_SYNC_PARITY_ERROR_TRANSLATION_TABLE_1ST_LEVEL:
149149
reason = K_ERR_ARM_SYNC_PARITY_ERROR_TRANSLATION_TABLE_1ST_LEVEL;

include/zephyr/arch/arm/arch.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ enum k_fatal_error_reason_arch {
115115
K_ERR_ARM_DOMAIN_FAULT_2ND_LEVEL,
116116
K_ERR_ARM_SYNC_EXTERNAL_ABORT_TRANSLATION_TABLE_1ST_LEVEL,
117117
K_ERR_ARM_SYNC_EXTERNAL_ABORT_TRANSLATION_TABLE_2ND_LEVEL,
118-
K_ERR_ARM_TLB_CONFLICT_FAULT,
118+
K_ERR_ARM_TLB_CONFLICT_ABORT,
119119
K_ERR_ARM_SYNC_PARITY_ERROR_TRANSLATION_TABLE_1ST_LEVEL,
120120
K_ERR_ARM_SYNC_PARITY_ERROR_TRANSLATION_TABLE_2ND_LEVEL,
121121
};

modules/cmsis/cmsis_core_a_r_ext.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
#define FSR_FS_PERMISSION_FAULT (13)
5151
#define FSR_FS_SYNC_EXTERNAL_ABORT_TRANSLATION_TABLE_2ND_LEVEL (14)
5252
#define FSR_FS_PERMISSION_FAULT_2ND_LEVEL (15)
53-
#define FSR_FS_TLB_CONFLICT_FAULT (16)
53+
#define FSR_FS_TLB_CONFLICT_ABORT (16)
5454
#define FSR_FS_ASYNC_EXTERNAL_ABORT (22)
5555
#define FSR_FS_ASYNC_PARITY_ERROR (24)
5656
#define FSR_FS_SYNC_PARITY_ERROR (25)

0 commit comments

Comments
 (0)