drivers: video: common: turn ASSERT(false) into CODE_UNREACHABLE

josuah · josuah · commit c32f8ff8448e · 2025-05-08T23:14:24.000Z
The assert message was not very helpful, CODE_UNREACHABLE is more
readable and requires fewer effort while proofreading.

Signed-off-by: Josuah Demangeon &lt;me@josuah.net&gt;
diff --git a/drivers/video/video_common.c b/drivers/video/video_common.c
@@ -148,7 +148,7 @@ void video_closest_frmival(const struct device *dev, enum video_endpoint_id ep,
 			video_closest_frmival_stepwise(&fie.stepwise, &desired, &tmp);
 			break;
 		default:
-			__ASSERT(false, "invalid answer from the queried video device");
+			CODE_UNREACHABLE;
 		}
 
 		tmp = video_frmival_nsec(&tmp);

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ void video_closest_frmival(const struct device *dev, enum video_endpoint_id ep,`
`148`	`148`	`video_closest_frmival_stepwise(&fie.stepwise, &desired, &tmp);`
`149`	`149`	`break;`
`150`	`150`	`default:`
`151`		`- __ASSERT(false, "invalid answer from the queried video device");`
	`151`	`+ CODE_UNREACHABLE;`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`tmp = video_frmival_nsec(&tmp);`