drivers: ethernet: phy: vsc8541: allow disabling autonegotiation

robhancocksed · robhancocksed · commit bdecf2dd7956 · 2025-06-24T13:03:22.000-06:00
Add support for disabling autonegotiation to the cfg_link callback, as
with the phy_mii driver.

Signed-off-by: Robert Hancock &lt;robert.hancock@calian.com&gt;
diff --git a/drivers/ethernet/phy/phy_microchip_vsc8541.c b/drivers/ethernet/phy/phy_microchip_vsc8541.c
@@ -277,12 +277,15 @@ static int phy_mc_vsc8541_get_speed(const struct device *dev, struct phy_link_st
 static int phy_mc_vsc8541_cfg_link(const struct device *dev, enum phy_link_speed adv_speeds,
 				   enum phy_cfg_link_flag flags)
 {
+	int ret;
+
 	if ((flags & PHY_FLAG_AUTO_NEGOTIATION_DISABLED) != 0U) {
-		LOG_ERR("Disabling auto-negotiation is not supported by this driver");
-		return -ENOTSUP;
+		ret = phy_mii_set_bmcr_reg_autoneg_disabled(dev, adv_speeds);
+	} else {
+		ret = phy_mii_cfg_link_autoneg(dev, adv_speeds, true);
 	}
 
-	return phy_mii_cfg_link_autoneg(dev, adv_speeds, true);
+	return ret;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -277,12 +277,15 @@ static int phy_mc_vsc8541_get_speed(const struct device *dev, struct phy_link_st`
`277`	`277`	`static int phy_mc_vsc8541_cfg_link(const struct device *dev, enum phy_link_speed adv_speeds,`
`278`	`278`	`enum phy_cfg_link_flag flags)`
`279`	`279`	`{`
	`280`	`+ int ret;`
	`281`	`+`
`280`	`282`	`if ((flags & PHY_FLAG_AUTO_NEGOTIATION_DISABLED) != 0U) {`
`281`		`- LOG_ERR("Disabling auto-negotiation is not supported by this driver");`
`282`		`- return -ENOTSUP;`
	`283`	`+ ret = phy_mii_set_bmcr_reg_autoneg_disabled(dev, adv_speeds);`
	`284`	`+ } else {`
	`285`	`+ ret = phy_mii_cfg_link_autoneg(dev, adv_speeds, true);`
`283`	`286`	`}`
`284`	`287`
`285`		`- return phy_mii_cfg_link_autoneg(dev, adv_speeds, true);`
	`288`	`+ return ret;`
`286`	`289`	`}`
`287`	`290`
`288`	`291`	`/**`