Skip to content

Commit bd2f4ef

Browse files
bricledanieldegrasse
authored andcommitted
drivers: modem_cellular: fix eg25g dial cmd response
eg25g modem should respond "CONNECT <text> " when run dial cmd "ATD" Signed-off-by: Shan Pen <bricle031@gmail.com>
1 parent 3b45fee commit bd2f4ef

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

drivers/modem/modem_cellular.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -525,9 +525,8 @@ MODEM_CHAT_MATCHES_DEFINE(dial_abort_matches,
525525
MODEM_CHAT_MATCH("NO CARRIER", "", NULL),
526526
MODEM_CHAT_MATCH("NO DIALTONE", "", NULL));
527527

528-
#if DT_HAS_COMPAT_STATUS_OKAY(swir_hl7800) || \
529-
DT_HAS_COMPAT_STATUS_OKAY(sqn_gm02s) || \
530-
DT_HAS_COMPAT_STATUS_OKAY(quectel_eg800q) || \
528+
#if DT_HAS_COMPAT_STATUS_OKAY(swir_hl7800) || DT_HAS_COMPAT_STATUS_OKAY(sqn_gm02s) || \
529+
DT_HAS_COMPAT_STATUS_OKAY(quectel_eg800q) || DT_HAS_COMPAT_STATUS_OKAY(quectel_eg25_g) || \
531530
DT_HAS_COMPAT_STATUS_OKAY(simcom_a76xx)
532531
MODEM_CHAT_MATCH_DEFINE(connect_match, "CONNECT", "", NULL);
533532
#endif
@@ -2018,10 +2017,10 @@ MODEM_CHAT_SCRIPT_DEFINE(quectel_eg25_g_init_chat_script, quectel_eg25_g_init_ch
20182017
MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_eg25_g_dial_chat_script_cmds,
20192018
MODEM_CHAT_SCRIPT_CMD_RESP_MULT("AT+CGACT=0,1", allow_match),
20202019
MODEM_CHAT_SCRIPT_CMD_RESP("AT+CGDCONT=1,\"IP\","
2021-
"\""CONFIG_MODEM_CELLULAR_APN"\"",
2020+
"\"" CONFIG_MODEM_CELLULAR_APN "\"",
20222021
ok_match),
20232022
MODEM_CHAT_SCRIPT_CMD_RESP("AT+CFUN=1", ok_match),
2024-
MODEM_CHAT_SCRIPT_CMD_RESP_NONE("ATD*99***1#", 0),);
2023+
MODEM_CHAT_SCRIPT_CMD_RESP("ATD*99***1#", connect_match));
20252024

20262025
MODEM_CHAT_SCRIPT_DEFINE(quectel_eg25_g_dial_chat_script, quectel_eg25_g_dial_chat_script_cmds,
20272026
dial_abort_matches, modem_cellular_chat_callback_handler, 10);

0 commit comments

Comments
 (0)