Skip to content

Commit b95d7e2

Browse files
josuahkartben
authored andcommitted
samples: drivers: video: capture: logging improvements
Remove trailing spaces at the end of log string. Move arguments on the next line for readability. Align arguments to first line. Signed-off-by: Josuah Demangeon <me@josuah.net>
1 parent d272c12 commit b95d7e2

File tree

1 file changed

+14
-14
lines changed
  • samples/drivers/video/capture/src

1 file changed

+14
-14
lines changed

samples/drivers/video/capture/src/main.c

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ static inline int display_setup(const struct device *const display_dev, const ui
3737

3838
LOG_INF("- Capabilities:");
3939
LOG_INF(" x_resolution = %u, y_resolution = %u, supported_pixel_formats = %u"
40-
" current_pixel_format = %u, current_orientation = %u",
41-
capabilities.x_resolution, capabilities.y_resolution,
42-
capabilities.supported_pixel_formats, capabilities.current_pixel_format,
43-
capabilities.current_orientation);
40+
" current_pixel_format = %u, current_orientation = %u",
41+
capabilities.x_resolution, capabilities.y_resolution,
42+
capabilities.supported_pixel_formats, capabilities.current_pixel_format,
43+
capabilities.current_orientation);
4444

4545
/* Set display pixel format to match the one in use by the camera */
4646
switch (pixfmt) {
@@ -138,9 +138,9 @@ int main(void)
138138
const struct video_format_cap *fcap = &caps.format_caps[i];
139139
/* fourcc to string */
140140
LOG_INF(" %s width [%u; %u; %u] height [%u; %u; %u]",
141-
VIDEO_FOURCC_TO_STR(fcap->pixelformat),
142-
fcap->width_min, fcap->width_max, fcap->width_step,
143-
fcap->height_min, fcap->height_max, fcap->height_step);
141+
VIDEO_FOURCC_TO_STR(fcap->pixelformat),
142+
fcap->width_min, fcap->width_max, fcap->width_step,
143+
fcap->height_min, fcap->height_max, fcap->height_step);
144144
i++;
145145
}
146146

@@ -173,20 +173,20 @@ int main(void)
173173

174174
if (!video_get_frmival(video_dev, &frmival)) {
175175
LOG_INF("- Default frame rate : %f fps",
176-
1.0 * frmival.denominator / frmival.numerator);
176+
1.0 * frmival.denominator / frmival.numerator);
177177
}
178178

179179
LOG_INF("- Supported frame intervals for the default format:");
180180
memset(&fie, 0, sizeof(fie));
181181
fie.format = &fmt;
182182
while (video_enum_frmival(video_dev, &fie) == 0) {
183183
if (fie.type == VIDEO_FRMIVAL_TYPE_DISCRETE) {
184-
LOG_INF(" %u/%u ", fie.discrete.numerator, fie.discrete.denominator);
184+
LOG_INF(" %u/%u", fie.discrete.numerator, fie.discrete.denominator);
185185
} else {
186186
LOG_INF(" [min = %u/%u; max = %u/%u; step = %u/%u]",
187-
fie.stepwise.min.numerator, fie.stepwise.min.denominator,
188-
fie.stepwise.max.numerator, fie.stepwise.max.denominator,
189-
fie.stepwise.step.numerator, fie.stepwise.step.denominator);
187+
fie.stepwise.min.numerator, fie.stepwise.min.denominator,
188+
fie.stepwise.max.numerator, fie.stepwise.max.denominator,
189+
fie.stepwise.step.numerator, fie.stepwise.step.denominator);
190190
}
191191
fie.index++;
192192
}
@@ -268,8 +268,8 @@ int main(void)
268268
return 0;
269269
}
270270

271-
LOG_DBG("Got frame %u! size: %u; timestamp %u ms", frame++, vbuf->bytesused,
272-
vbuf->timestamp);
271+
LOG_DBG("Got frame %u! size: %u; timestamp %u ms",
272+
frame++, vbuf->bytesused, vbuf->timestamp);
273273

274274
#ifdef CONFIG_TEST
275275
if (is_colorbar_ok(vbuf->buffer, fmt)) {

0 commit comments

Comments
 (0)