include: common: sys_bitops: Specify sign when bitshifting

rugeGerritsen · kartben · commit b8bff65fcb73 · 2025-06-02T20:22:20.000+02:00
When left-shifting '1' by 31, the result is undefined. This is
something ASAN detects.

Solve this by explicitly defining that the integer is unsigned.

Signed-off-by: Rubin Gerritsen &lt;rubin.gerritsen@nordicsemi.no&gt;
diff --git a/include/zephyr/arch/common/sys_bitops.h b/include/zephyr/arch/common/sys_bitops.h
@@ -25,21 +25,21 @@ static ALWAYS_INLINE void sys_set_bit(mem_addr_t addr, unsigned int bit)
 {
 	uint32_t temp = *(volatile uint32_t *)addr;
 
-	*(volatile uint32_t *)addr = temp | (1 << bit);
+	*(volatile uint32_t *)addr = temp | (1U << bit);
 }
 
 static ALWAYS_INLINE void sys_clear_bit(mem_addr_t addr, unsigned int bit)
 {
 	uint32_t temp = *(volatile uint32_t *)addr;
 
-	*(volatile uint32_t *)addr = temp & ~(1 << bit);
+	*(volatile uint32_t *)addr = temp & ~(1U << bit);
 }
 
 static ALWAYS_INLINE int sys_test_bit(mem_addr_t addr, unsigned int bit)
 {
 	uint32_t temp = *(volatile uint32_t *)addr;
 
-	return temp & (1 << bit);
+	return temp & (1U << bit);
 }
 
 static ALWAYS_INLINE void sys_set_bits(mem_addr_t addr, unsigned int mask)

Original file line number	Diff line number	Diff line change
`@@ -25,21 +25,21 @@ static ALWAYS_INLINE void sys_set_bit(mem_addr_t addr, unsigned int bit)`
`25`	`25`	`{`
`26`	`26`	`uint32_t temp = (volatile uint32_t )addr;`
`27`	`27`
`28`		`- (volatile uint32_t )addr = temp \| (1 << bit);`
	`28`	`+ (volatile uint32_t )addr = temp \| (1U << bit);`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`static ALWAYS_INLINE void sys_clear_bit(mem_addr_t addr, unsigned int bit)`
`32`	`32`	`{`
`33`	`33`	`uint32_t temp = (volatile uint32_t )addr;`
`34`	`34`
`35`		`- (volatile uint32_t )addr = temp & ~(1 << bit);`
	`35`	`+ (volatile uint32_t )addr = temp & ~(1U << bit);`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`static ALWAYS_INLINE int sys_test_bit(mem_addr_t addr, unsigned int bit)`
`39`	`39`	`{`
`40`	`40`	`uint32_t temp = (volatile uint32_t )addr;`
`41`	`41`
`42`		`- return temp & (1 << bit);`
	`42`	`+ return temp & (1U << bit);`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`static ALWAYS_INLINE void sys_set_bits(mem_addr_t addr, unsigned int mask)`