Bluetooth: SSP: Incorrect bonding status notified

The `bonded` flag of the callback `pairing_complete` is always true,
event if the SSP pairing is non-bondable.

Check the bonding status in SSP complete event instead of in link key
notify event.

Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

Author: lylezhu2012

subsys/bluetooth/host/classic/ssp.c

@@ -479,11 +479,6 @@ void bt_hci_link_key_notify(struct net_buf *buf)
 		conn->br.link_key->flags |= BT_LINK_KEY_AUTHENTICATED;
 		__fallthrough;
 	case BT_LK_UNAUTH_COMBINATION_P192:
-		/* Mark no-bond so that link-key is removed on disconnection */
-		if (ssp_get_auth(conn) < BT_HCI_DEDICATED_BONDING) {
-			atomic_set_bit(conn->flags, BT_CONN_BR_NOBOND);
-		}
-
 		memcpy(conn->br.link_key->val, evt->link_key, 16);
 		break;
 	case BT_LK_AUTH_COMBINATION_P256:
@@ -492,11 +487,6 @@ void bt_hci_link_key_notify(struct net_buf *buf)
 	case BT_LK_UNAUTH_COMBINATION_P256:
 		conn->br.link_key->flags |= BT_LINK_KEY_SC;
 
-		/* Mark no-bond so that link-key is removed on disconnection */
-		if (ssp_get_auth(conn) < BT_HCI_DEDICATED_BONDING) {
-			atomic_set_bit(conn->flags, BT_CONN_BR_NOBOND);
-		}
-
 		memcpy(conn->br.link_key->val, evt->link_key, 16);
 		break;
 	default:
@@ -720,6 +710,11 @@ void bt_hci_ssp_complete(struct net_buf *buf)
 		return;
 	}
 
+	/* Mark no-bond so that link-key will be removed on disconnection */
+	if (ssp_get_auth(conn) < BT_HCI_DEDICATED_BONDING) {
+		atomic_set_bit(conn->flags, BT_CONN_BR_NOBOND);
+	}
+
 	ssp_pairing_complete(conn, bt_security_err_get(evt->status));
 	if (evt->status) {
 		bt_conn_disconnect(conn, BT_HCI_ERR_AUTH_FAIL);