Skip to content

Commit aa6ac8e

Browse files
Thalleydkalowsk
authored andcommitted
Samples: Bluetooth: HR: Remove use of ISO config for IPC
When compiling with sysbuild and IPC the samples would use the nrf5340_cpunet_iso-bt_ll_sw_split.conf config file, which was incompatible with the sample's host configuration. Instead of using the ISO configuration file, define a hci_ipc overlay in each sample with the necessary configurations that support all host configurations. This commit also updates the sample.yaml files to split configurations for single- and multicore builds, as what needs to be configured for each type is different. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
1 parent 09a270e commit aa6ac8e

File tree

6 files changed

+77
-20
lines changed

6 files changed

+77
-20
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Configuration file to be used as an overlay to the hci_ipc sample for multi-core boards
2+
3+
CONFIG_BT_EXT_ADV=y
4+
5+
# Enable Coded PHY support
6+
CONFIG_BT_CTLR_PHY_CODED=y
7+
8+
# Increase Advertising Data Length, as Complete Local Name too needs to be
9+
# placed in the AUX_ADV_IND PDU compared to when it is placed in ADV_SCAN_IND
10+
# PDU in the case of legacy advertising.
11+
CONFIG_BT_CTLR_SCAN_DATA_LEN_MAX=36

samples/bluetooth/central_hr/sample.yaml

Lines changed: 25 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,31 +17,48 @@ tests:
1717
harness: bluetooth
1818
platform_allow:
1919
- nrf52_bsim
20-
- nrf5340bsim/nrf5340/cpuapp
2120
- nrf52dk/nrf52832
2221
- nrf52840dk/nrf52840
23-
- nrf5340dk/nrf5340/cpuapp
2422
integration_platforms:
2523
- nrf52_bsim
26-
- nrf5340bsim/nrf5340/cpuapp
2724
- nrf52dk/nrf52832
2825
- nrf52840dk/nrf52840
29-
- nrf5340dk/nrf5340/cpuapp
3026
extra_args: EXTRA_CONF_FILE=overlay-extended.conf
3127
tags: bluetooth
28+
sample.bluetooth.central_hr.multicore.bt_ll_sw_split.extended:
29+
harness: bluetooth
30+
platform_allow:
31+
- nrf5340bsim/nrf5340/cpuapp
32+
- nrf5340dk/nrf5340/cpuapp
33+
integration_platforms:
34+
- nrf5340bsim/nrf5340/cpuapp
35+
- nrf5340dk/nrf5340/cpuapp
36+
extra_args:
37+
- CONFIG_BT_EXT_ADV=y
38+
tags: bluetooth
39+
sysbuild: true
3240
sample.bluetooth.central_hr.bt_ll_sw_split.phy_coded:
3341
harness: bluetooth
3442
platform_allow:
3543
- nrf52_bsim
36-
- nrf5340bsim/nrf5340/cpuapp
3744
- nrf52dk/nrf52832
3845
- nrf52840dk/nrf52840
39-
- nrf5340dk/nrf5340/cpuapp
4046
integration_platforms:
4147
- nrf52_bsim
42-
- nrf5340bsim/nrf5340/cpuapp
4348
- nrf52dk/nrf52832
4449
- nrf52840dk/nrf52840
45-
- nrf5340dk/nrf5340/cpuapp
4650
extra_args: EXTRA_CONF_FILE=overlay-phy_coded.conf
4751
tags: bluetooth
52+
sample.bluetooth.central_hr.multicore.bt_ll_sw_split.phy_coded:
53+
harness: bluetooth
54+
platform_allow:
55+
- nrf5340bsim/nrf5340/cpuapp
56+
- nrf5340dk/nrf5340/cpuapp
57+
integration_platforms:
58+
- nrf5340bsim/nrf5340/cpuapp
59+
- nrf5340dk/nrf5340/cpuapp
60+
extra_args:
61+
- CONFIG_BT_EXT_ADV=y
62+
- CONFIG_BT_AUTO_PHY_UPDATE=n
63+
tags: bluetooth
64+
sysbuild: true

samples/bluetooth/central_hr/sysbuild.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ if(SB_CONFIG_NET_CORE_IMAGE_HCI_IPC)
1313
BOARD ${SB_CONFIG_NET_CORE_BOARD}
1414
)
1515

16-
set(${NET_APP}_CONF_FILE
17-
${NET_APP_SRC_DIR}/nrf5340_cpunet_iso-bt_ll_sw_split.conf
16+
set(${NET_APP}_EXTRA_CONF_FILE
17+
${ZEPHYR_BASE}/samples/bluetooth/central_hr/overlay-bt_ll_sw_split.conf
1818
CACHE INTERNAL ""
1919
)
2020

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Configuration file to be used as an overlay to the hci_ipc sample for multi-core boards
2+
3+
CONFIG_BT_EXT_ADV=y
4+
5+
# Enable Coded PHY support
6+
CONFIG_BT_CTLR_PHY_CODED=y
7+
8+
# Increase Advertising Data Length, as Complete Local Name too needs to be
9+
# placed in the AUX_ADV_IND PDU compared to when it is placed in ADV_SCAN_IND
10+
# PDU in the case of legacy advertising.
11+
CONFIG_BT_CTLR_ADV_DATA_LEN_MAX=36

samples/bluetooth/peripheral_hr/sample.yaml

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ tests:
2626
- nrf54l15dk/nrf54l15/cpuapp
2727
- ophelia4ev/nrf54l15/cpuapp
2828
tags: bluetooth
29+
sysbuild: true
2930
sample.bluetooth.peripheral_hr.minimal:
3031
harness: bluetooth
3132
platform_allow:
@@ -38,34 +39,51 @@ tests:
3839
harness: bluetooth
3940
platform_allow:
4041
- nrf52_bsim
41-
- nrf5340bsim/nrf5340/cpuapp
4242
- nrf52dk/nrf52832
4343
- nrf52840dk/nrf52840
44-
- nrf5340dk/nrf5340/cpuapp
4544
integration_platforms:
4645
- nrf52_bsim
47-
- nrf5340bsim/nrf5340/cpuapp
4846
- nrf52dk/nrf52832
4947
- nrf52840dk/nrf52840
50-
- nrf5340dk/nrf5340/cpuapp
5148
extra_args: EXTRA_CONF_FILE=overlay-extended.conf
5249
tags: bluetooth
50+
sample.bluetooth.peripheral_hr.multicore.bt_ll_sw_split.extended:
51+
harness: bluetooth
52+
platform_allow:
53+
- nrf5340bsim/nrf5340/cpuapp
54+
- nrf5340dk/nrf5340/cpuapp
55+
integration_platforms:
56+
- nrf5340bsim/nrf5340/cpuapp
57+
- nrf5340dk/nrf5340/cpuapp
58+
extra_args: CONFIG_BT_EXT_ADV=y
59+
tags: bluetooth
60+
sysbuild: true
5361
sample.bluetooth.peripheral_hr.bt_ll_sw_split.phy_coded:
5462
harness: bluetooth
5563
platform_allow:
5664
- nrf52_bsim
57-
- nrf5340bsim/nrf5340/cpuapp
5865
- nrf52dk/nrf52832
5966
- nrf52840dk/nrf52840
60-
- nrf5340dk/nrf5340/cpuapp
6167
integration_platforms:
6268
- nrf52_bsim
63-
- nrf5340bsim/nrf5340/cpuapp
6469
- nrf52dk/nrf52832
6570
- nrf52840dk/nrf52840
66-
- nrf5340dk/nrf5340/cpuapp
6771
extra_args: EXTRA_CONF_FILE=overlay-phy_coded.conf
6872
tags: bluetooth
73+
sysbuild: true
74+
sample.bluetooth.peripheral_hr.multicore.bt_ll_sw_split.phy_coded:
75+
harness: bluetooth
76+
platform_allow:
77+
- nrf5340bsim/nrf5340/cpuapp
78+
- nrf5340dk/nrf5340/cpuapp
79+
integration_platforms:
80+
- nrf5340bsim/nrf5340/cpuapp
81+
- nrf5340dk/nrf5340/cpuapp
82+
extra_args:
83+
- CONFIG_BT_EXT_ADV=y
84+
- CONFIG_BT_AUTO_PHY_UPDATE=n
85+
tags: bluetooth
86+
sysbuild: true
6987
sample.bluetooth.peripheral_hr_rv32m1_vega_openisa_rv32m1_ri5cy:
7088
platform_allow: rv32m1_vega/openisa_rv32m1/ri5cy
7189
tags: bluetooth

samples/bluetooth/peripheral_hr/sysbuild.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ if(SB_CONFIG_NET_CORE_IMAGE_HCI_IPC)
1313
BOARD ${SB_CONFIG_NET_CORE_BOARD}
1414
)
1515

16-
set(${NET_APP}_CONF_FILE
17-
${NET_APP_SRC_DIR}/nrf5340_cpunet_iso-bt_ll_sw_split.conf
16+
set(${NET_APP}_EXTRA_CONF_FILE
17+
${ZEPHYR_BASE}/samples/bluetooth/peripheral_hr/overlay-bt_ll_sw_split.conf
1818
CACHE INTERNAL ""
1919
)
2020

0 commit comments

Comments
 (0)