Skip to content

Commit aa4a878

Browse files
rlubosdanieldegrasse
authored andcommitted
net: sockets: socket_dispatcher: Fix close function type
Socket dispatcher (and offloaded implementations in tests) register fd as ZVFS_MODE_IFSOCK therefore they should register a close2( function instead of close(). Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
1 parent a4fdd2c commit aa4a878

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

subsys/net/lib/sockets/socket_dispatcher.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,10 @@ static int sock_dispatch_setsockopt_vmeth(void *obj, int level, int optname,
393393
return zsock_setsockopt(fd, level, optname, optval, optlen);
394394
}
395395

396-
static int sock_dispatch_close_vmeth(void *obj)
396+
static int sock_dispatch_close_vmeth(void *obj, int fd)
397397
{
398+
ARG_UNUSED(fd);
399+
398400
dispatcher_ctx_free(obj);
399401

400402
return 0;
@@ -428,7 +430,7 @@ static const struct socket_op_vtable sock_dispatch_fd_op_vtable = {
428430
.fd_vtable = {
429431
.read = sock_dispatch_read_vmeth,
430432
.write = sock_dispatch_write_vmeth,
431-
.close = sock_dispatch_close_vmeth,
433+
.close2 = sock_dispatch_close_vmeth,
432434
.ioctl = sock_dispatch_ioctl_vmeth,
433435
},
434436
.shutdown = sock_dispatch_shutdown_vmeth,

tests/net/socket/offload_dispatcher/src/main.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,12 @@ static ssize_t offload_write(void *obj, const void *buffer, size_t count)
6161
return 0;
6262
}
6363

64-
static int offload_close(void *obj)
64+
static int offload_close(void *obj, int fd)
6565
{
6666
struct test_socket_calls *ctx = obj;
6767

68+
ARG_UNUSED(fd);
69+
6870
ctx->close_called = true;
6971

7072
return 0;
@@ -252,7 +254,7 @@ static const struct socket_op_vtable offload_1_socket_fd_op_vtable = {
252254
.fd_vtable = {
253255
.read = offload_read,
254256
.write = offload_write,
255-
.close = offload_close,
257+
.close2 = offload_close,
256258
.ioctl = offload_ioctl,
257259
},
258260
.shutdown = offload_shutdown,
@@ -314,7 +316,7 @@ static const struct socket_op_vtable offload_2_socket_fd_op_vtable = {
314316
.fd_vtable = {
315317
.read = offload_read,
316318
.write = offload_write,
317-
.close = offload_close,
319+
.close2 = offload_close,
318320
.ioctl = offload_ioctl,
319321
},
320322
.shutdown = offload_shutdown,

0 commit comments

Comments
 (0)