Skip to content

Commit 9b428c8

Browse files
katgiadladanieldegrasse
authored andcommitted
twister: Fix tests statuses if quarantine is verified
If test configuration is not quarantined and `--quarantine-verify` mode is enabled, these should be filtered and not attached to reports. Proposed change applies this approach. Signed-off-by: Katarzyna Giądła <katarzyna.giadla@nordicsemi.no>
1 parent e31f9bf commit 9b428c8

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

scripts/pylib/twister/twisterlib/testplan.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -607,8 +607,7 @@ def handle_quarantined_tests(self, instance: TestInstance, plat: Platform):
607607
instance.reason = "Quarantine: " + matched_quarantine
608608
return
609609
if not matched_quarantine and self.options.quarantine_verify:
610-
instance.status = TwisterStatus.SKIP
611-
instance.reason = "Not under quarantine"
610+
instance.add_filter("Not under quarantine", Filters.CMD_LINE)
612611

613612
def load_from_file(self, file, filter_platform=None):
614613
if filter_platform is None:

scripts/tests/twister/test_testplan.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ def test_quarantine_short(class_testplan, platforms_list, test_data,
342342
if testname in expected_val:
343343
assert instance.status == TwisterStatus.NONE
344344
else:
345-
assert instance.status == TwisterStatus.SKIP
345+
assert instance.status == TwisterStatus.FILTER
346346
assert instance.reason == "Not under quarantine"
347347
else:
348348
if testname in expected_val:

0 commit comments

Comments
 (0)