drivers: ethernet: phy: dm8806: fix error handling

kartben · kartben · commit 942d823c713e · 2025-06-23T09:46:10.000+02:00
Use signed variable for negative error codes so that potential errors
are actually detected and returned properly.

Signed-off-by: Benjamin Cabé &lt;benjamin@zephyrproject.org&gt;
diff --git a/drivers/ethernet/phy/phy_dm8806.c b/drivers/ethernet/phy/phy_dm8806.c
@@ -525,7 +525,7 @@ static int phy_dm8806_get_link_state(const struct device *dev, struct phy_link_s
 static int phy_dm8806_cfg_link(const struct device *dev, enum phy_link_speed adv_speeds,
 			       enum phy_cfg_link_flag flags)
 {
-	uint8_t ret;
+	int ret;
 	uint16_t data;
 	uint16_t req_speed;
 	const struct phy_dm8806_config *cfg = dev->config;

Original file line number	Diff line number	Diff line change
`@@ -525,7 +525,7 @@ static int phy_dm8806_get_link_state(const struct device *dev, struct phy_link_s`
`525`	`525`	`static int phy_dm8806_cfg_link(const struct device *dev, enum phy_link_speed adv_speeds,`
`526`	`526`	`enum phy_cfg_link_flag flags)`
`527`	`527`	`{`
`528`		`- uint8_t ret;`
	`528`	`+ int ret;`
`529`	`529`	`uint16_t data;`
`530`	`530`	`uint16_t req_speed;`
`531`	`531`	`const struct phy_dm8806_config *cfg = dev->config;`