net: websocket: fix masked data when server sends close

EricNRS · kartben · commit 84d3cafbce3e · 2025-04-04T14:56:58.000+02:00
When sending the close command as a server, the data is incorrectly
masked which violates RFC6455 section 5.1.

Use the is_client flag to avoid masking if the close is for a websocket
server.

Signed-off-by: Eric Holmberg &lt;eric.holmberg@northriversystems.co.nz&gt;
diff --git a/subsys/net/lib/websocket/websocket.c b/subsys/net/lib/websocket/websocket.c
@@ -421,7 +421,7 @@ static int websocket_interal_disconnect(struct websocket_context *ctx)
 	NET_DBG("[%p] Disconnecting", ctx);
 
 	ret = websocket_send_msg(ctx->sock, NULL, 0, WEBSOCKET_OPCODE_CLOSE,
-				 true, true, SYS_FOREVER_MS);
+				 ctx->is_client, true, SYS_FOREVER_MS);
 	if (ret < 0) {
 		NET_DBG("[%p] Failed to send close message (err %d).", ctx, ret);
 	}

Original file line number	Diff line number	Diff line change
`@@ -421,7 +421,7 @@ static int websocket_interal_disconnect(struct websocket_context *ctx)`
`421`	`421`	`NET_DBG("[%p] Disconnecting", ctx);`
`422`	`422`
`423`	`423`	`ret = websocket_send_msg(ctx->sock, NULL, 0, WEBSOCKET_OPCODE_CLOSE,`
`424`		`- true, true, SYS_FOREVER_MS);`
	`424`	`+ ctx->is_client, true, SYS_FOREVER_MS);`
`425`	`425`	`if (ret < 0) {`
`426`	`426`	`NET_DBG("[%p] Failed to send close message (err %d).", ctx, ret);`
`427`	`427`	`}`