Polishing

- Add support for read-only flag
- Cleanup LOGs
- forward declaration of static functions
- Sample: Updated README, kconfig and prj

Author: ExtremeGTX

samples/subsys/usb/mtp/README.rst

@@ -2,7 +2,7 @@
    :name: USB MTP
    :relevant-api: usbd_api _usb_device_core_api file_system_api
 
-   Use USB MTP driver which implement a Media Transfer Protocol device.
+   Expose the selected storage partition(s) as USB Media device using Media Transfer Protocol driver.
 
 Overview
 ********
@@ -17,13 +17,14 @@ Zephyr project tree.
 Requirements
 ************
 
-This project requires:
 - USB device driver support
 - Storage media with Littlefs/FAT filesystem support
 
 Building and Running
 ********************
 
+This sample can be built for multiple boards which can support at least one storage parition.
+
 Reel Board
 ===========
 
@@ -68,12 +69,12 @@ If the device is not recognized properly:
 1. Ensure the storage medium is properly initialized
 2. Check that the filesystem is mounted correctly
 3. Verify USB configuration is correct for your board
-4. Some systems may require additional MTP device support to be installed
+4. Enable DEBUG logs on USB MTP driver to get more information
 
 For debugging purposes, you can enable USB debug logs by setting the following
 in your project's configuration:
 
 .. code-block:: none
 
    CONFIG_USB_DEVICE_LOG_LEVEL_DBG=y
-   CONFIG_USB_MTP_LOG_LEVEL_DBG=y
+   CONFIG_USB_MTP_LOG_LEVEL_DBG=y

samples/subsys/usb/mtp/prj.conf

@@ -38,4 +38,4 @@ CONFIG_OUTPUT_DISASSEMBLY_WITH_SOURCE=y
 CONFIG_FLASH_SHELL=y
 CONFIG_HWINFO_SHELL=y
 CONFIG_LOG_CMDS=y
-CONFIG_USBD_MTP_LOG_LEVEL_DBG=y
+CONFIG_USBD_MTP_LOG_LEVEL_DBG=y

samples/subsys/usb/mtp/src/main.c

@@ -1,27 +1,25 @@
 /*
  * Copyright (c) 2019 Intel Corporation
+ * Copyright (c) 2025 Mohamed ElShahawi (extremegtx@hotmail.com)
  *
  * SPDX-License-Identifier: Apache-2.0
  */
 
 /**
  * @file
- * @brief Sample echo app for MTP class
+ * @brief Sample app app for MTP class
  *
- * Sample app for USB MTP class driver.
+ * Sample app for USB MTP class driver. By default MTP class driver will expose
+ * all storage parititions which has the flag `mtp-enabled`
  */
 
 #include <sample_usbd.h>
 
-#include <stdio.h>
-#include <string.h>
-#include <zephyr/device.h>
 #include <zephyr/kernel.h>
-
 #include <zephyr/usb/usb_device.h>
 #include <zephyr/usb/usbd.h>
 #include <zephyr/logging/log.h>
-LOG_MODULE_REGISTER(main, LOG_LEVEL_DBG);
+LOG_MODULE_REGISTER(usb_mtp_sample, LOG_LEVEL_INF);
 
 static struct usbd_context *sample_usbd;
 
@@ -67,12 +65,13 @@ static int enable_usb_device_next(void)
 	return 0;
 }
 
-
 int main(void)
 {
 	int ret;
-
+#if defined(CONFIG_USB_DEVICE_STACK_NEXT)
 	ret = enable_usb_device_next();
-
+#else
+	#error "Only Device next is supported"
+#endif
 	return 0;
 }

subsys/usb/device_next/class/Kconfig.mtp

@@ -12,6 +12,7 @@ if USBD_MTP_CLASS
 
 config USBD_MTP_ALLOW_WRITE
 	bool "MTP Allow write"
+	default y
 	help
 	  Allow writing to the storage exposed over MTP.
 	  storage protection level has precedence over this config
@@ -23,16 +24,6 @@ config USBD_MTP_MAX_HANDLES
 	  Maximum number of objects to be handled by MTP, including
 	  stored, removed and added objects.
 
-config USBD_MTP_ALLOW_MOVING_OBJECTS
-	bool "MTP Allow move"
-	help
-	  Enable moving objects within the exposed storage without relying on the host.
-
-config USBD_MTP_ALLOW_COPYING_OBJECTS
-	bool "MTP Allow copy"
-	help
-	  Enable copying objects within the exposed storage without relying on the host.
-
 module = USBD_MTP
 module-str = usbd mtp
 default-count = 1

subsys/usb/device_next/class/usbd_mtp.c

@@ -237,7 +237,6 @@ static int usbd_mtp_request_handler(struct usbd_class_data *c_data, struct net_b
 		LOG_INF(BOLDWHITE
 			"\n=============[Host ACK handling END]=============\n" RESET);
 	} else {
-		LOG_ERR("SHOULDN'T BE HERE! buf->len: %u", buf->len);
 		__ASSERT(0, "Invalid endpoint %x", bi->ep);
 	}