Skip to content

Commit 77a7cb3

Browse files
ananglkartben
authored andcommitted
drivers: clock_control_nrf: Prevent break from becoming dead code
When both NRF_CLOCK_HAS_XO_TUNE and NRF_CLOCK_HAS_PLL evaluate to 0, one break statement can end up not associated with any case and become dead code. Refactor a bit the related switch to avoid such situation. Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
1 parent d963fc0 commit 77a7cb3

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

drivers/clock_control/clock_control_nrf.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -692,6 +692,10 @@ static void clock_event_handler(nrfx_clock_evt_type_t event)
692692
case NRFX_CLOCK_EVT_XO_TUNED:
693693
clkstarted_handle(dev, CLOCK_CONTROL_NRF_TYPE_HFCLK);
694694
break;
695+
case NRFX_CLOCK_EVT_XO_TUNE_ERROR:
696+
case NRFX_CLOCK_EVT_XO_TUNE_FAILED:
697+
/* No processing needed. */
698+
break;
695699
case NRFX_CLOCK_EVT_HFCLK_STARTED:
696700
/* HFCLK is stable after XOTUNED event.
697701
* HFCLK_STARTED means only that clock has been started.
@@ -743,15 +747,9 @@ static void clock_event_handler(nrfx_clock_evt_type_t event)
743747
#endif
744748
#if NRF_CLOCK_HAS_PLL
745749
case NRFX_CLOCK_EVT_PLL_STARTED:
746-
#endif
747-
#if NRF_CLOCK_HAS_XO_TUNE
748-
case NRFX_CLOCK_EVT_XO_TUNE_ERROR:
749-
case NRFX_CLOCK_EVT_XO_TUNE_FAILED:
750-
#endif
751-
{
752-
/* unhandled event */
750+
/* No processing needed. */
753751
break;
754-
}
752+
#endif
755753
default:
756754
__ASSERT_NO_MSG(0);
757755
break;

0 commit comments

Comments
 (0)