sca: eclair: use MISRA C:2012 Amendment 2

Use MISRA C:2012 Amendment 2 instead of 'MISRA C:2012 Amendment 2' in
all configuration files consistently.

Also fix a typo in one of the deviations.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>

Author: nashif

cmake/sca/eclair/ECL/adopted_deviations.ecl

@@ -4,14 +4,14 @@
 -report_selector+={adopted_report,"all_area(!kind(culprit||evidence)||all_loc(all_exp(adopted||pseudo)))"}
 
 -doc_begin="Adopted code is not meant to be read, reviewed or modified by human programmers:no developers' confusion is not possible. In addition, adopted code is assumed to work as is. Reports that are fully contained in adopted code are hidden/tagged with the 'adopted' tag."
--config=MC3R1.R7.2,reports+={relied,adopted_report}
--config=MC3R1.R10.3,reports+={relied,adopted_report}
--config=MC3R1.R10.6,reports+={relied,adopted_report}
--config=MC3R1.R12.1,reports+={relied,adopted_report}
+-config=MC3A2.R7.2,reports+={relied,adopted_report}
+-config=MC3A2.R10.3,reports+={relied,adopted_report}
+-config=MC3A2.R10.6,reports+={relied,adopted_report}
+-config=MC3A2.R12.1,reports+={relied,adopted_report}
 -doc_end
 
 -doc_begin="Macro LOAPIC_BASE_ADDRESS, automatically generated by Autoconf, expands to an implicitly unsigned literal lacking the 'u' or 'U' suffix."
--config=MC3R1.R7.2,reports+={safe,"all_area(all_loc(any_exp(macro(^assert$))))"}
+-config=MC3A2.R7.2,reports+={safe,"all_area(all_loc(any_exp(macro(^assert$))))"}
 -doc_end
 
 -doc="#include_next is a documented GNU preprocessing directive. See section \"2.7 Wrapper Headers\" of "CPP_MANUAL""
@@ -21,23 +21,23 @@
 
 -doc="The declarations in files tagged with api:public define a public API of Zephyr.
 Declarations in these files not necessarily have to be referenced."
--config=MC3R1.R2.3,declarations+={safe,"loc(top(public()))"}
+-config=MC3A2.R2.3,declarations+={safe,"loc(top(public()))"}
 
 -doc="Library entry points not necessarily have to be referenced."
--config=MC3R1.R2.1,declarations+={safe,"loc(top(public()))"}
+-config=MC3A2.R2.1,declarations+={safe,"loc(top(public()))"}
 
 -doc="Library entry points not necessarily have to be referenced in more than one translation units."
--config=MC3R1.R8.7,declarations+={safe,"loc(top(public()))"}
+-config=MC3A2.R8.7,declarations+={safe,"loc(top(public()))"}
 
 -doc="Syscall declarations are automatically generated all with the extern qualifier. For the ones with internal linkage the use of the extern qualifier is a violation of rule 8.8."
--config=MC3R1.R8.8,declarations={relied, "^z_vrfy_.*$||^z_impl_.*$"}
+-config=MC3A2.R8.8,declarations={relied, "^z_vrfy_.*$||^z_impl_.*$"}
 
 -doc="Function hash, that is automatically generated, does not use the parameter \"len\" in all its definitions."
--config=MC3R1.R2.7,declarations+={relied,"context(^hash\\(const char\\*, size_t\\)$)&&name(len)"}
+-config=MC3A2.R2.7,declarations+={relied,"context(^hash\\(const char\\*, size_t\\)$)&&name(len)"}
 
 -doc="Function \"z_object_lookup\", that is automatically generated, uses single-statement bodies not enclosed in braces."
--config=MC3R1.R15.6,reports={relied, "all_area(context(^z_object_lookup\\(const char\\*, size_t\\)$))"}
+-config=MC3A2.R15.6,reports={relied, "all_area(context(^z_object_lookup\\(const char\\*, size_t\\)$))"}
 
 -doc="The following declarations are in generated files: not in all configuration they are implemented.
     Chainging the generators could be dangerous and the advantages in enforcing the rule do not outweight these dangers."
--config=MC3R1.R8.6,declarations+={safe, "loc(top(file(^zephyr/build/zephyr/include/generated/.*$)))"}
+-config=MC3A2.R8.6,declarations+={safe, "loc(top(file(^zephyr/build/zephyr/include/generated/.*$)))"}

cmake/sca/eclair/ECL/analysis_STU.ecl

@@ -10,106 +10,106 @@
 
 -doc_begin="Selection of guidelines from
 https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html"
--enable=MC3R1.D4.13
--enable=MC3R1.D4.2
--enable=MC3R1.D4.4
--enable=MC3R1.D4.5
--enable=MC3R1.D4.8
--enable=MC3R1.D4.11
--enable=MC3R1.D4.12
--enable=MC3R1.D4.14
--enable=MC3R1.D4.7
--enable=MC3R1.R10.5
--enable=MC3R1.R10.2
--enable=MC3R1.R10.6
--enable=MC3R1.R10.7
--enable=MC3R1.R10.8
--enable=MC3R1.R1.2
--enable=MC3R1.R1.3
--enable=MC3R1.R12.4
--enable=MC3R1.R12.5
--enable=MC3R1.R12.2
--enable=MC3R1.R13.4
--enable=MC3R1.R13.1
--enable=MC3R1.R13.2
--enable=MC3R1.R13.5
--enable=MC3R1.R13.6
--enable=MC3R1.R18.5
--enable=MC3R1.R18.1
--enable=MC3R1.R18.2
--enable=MC3R1.R18.3
--enable=MC3R1.R18.6
--enable=MC3R1.R18.8
--enable=MC3R1.R21.11
--enable=MC3R1.R21.13
--enable=MC3R1.R21.17
--enable=MC3R1.R21.18
--enable=MC3R1.R21.19
--enable=MC3R1.R21.20
--enable=MC3R1.R2.7
--enable=MC3R1.R2.2
--enable=MC3R1.R4.2
--enable=MC3R1.R4.1
--enable=MC3R1.R17.3
--enable=MC3R1.R17.4
--enable=MC3R1.R17.6
--enable=MC3R1.R17.1
--enable=MC3R1.R17.5
--enable=MC3R1.R19.1
--enable=MC3R1.R22.2
--enable=MC3R1.R22.5
--enable=MC3R1.R22.6
--enable=MC3R1.R9.1
--enable=MC3R1.R9.2
--enable=MC3R1.R9.3
--enable=MC3R1.R9.4
--enable=MC3R1.R9.5
--enable=MC3R1.D2.1
--enable=MC3R1.R11.2
--enable=MC3R1.R11.6
--enable=MC3R1.R11.7
--enable=MC3R1.R11.8
--enable=MC3R1.R11.9
--enable=MC3R1.R14.1
--enable=MC3R1.R14.2
--enable=MC3R1.R14.3
--enable=MC3R1.R15.2
--enable=MC3R1.R15.3
--enable=MC3R1.R15.6
--enable=MC3R1.R15.7
--enable=MC3R1.R16.1
--enable=MC3R1.R16.2
--enable=MC3R1.R16.3
--enable=MC3R1.R16.4
--enable=MC3R1.R16.5
--enable=MC3R1.R16.6
--enable=MC3R1.R16.7
--enable=MC3R1.R20.11
--enable=MC3R1.R20.12
--enable=MC3R1.R20.13
--enable=MC3R1.R20.14
--enable=MC3R1.R20.2
--enable=MC3R1.R20.3
--enable=MC3R1.R20.4
--enable=MC3R1.R20.8
--enable=MC3R1.R20.9
--enable=MC3R1.R3.1
--enable=MC3R1.R3.2
--enable=MC3R1.R5.2
--enable=MC3R1.R5.3
--enable=MC3R1.R5.4
--enable=MC3R1.R5.5
--enable=MC3R1.R6.1
--enable=MC3R1.R6.2
--enable=MC3R1.R7.1
--enable=MC3R1.R7.2
--enable=MC3R1.R7.3
--enable=MC3R1.R7.4
--enable=MC3R1.R8.1
--enable=MC3R1.R8.10
--enable=MC3R1.R8.12
--enable=MC3R1.R8.14
--enable=MC3R1.R8.2
--enable=MC3R1.R8.4
--enable=MC3R1.R8.8
+-enable=MC3A2.D4.13
+-enable=MC3A2.D4.2
+-enable=MC3A2.D4.4
+-enable=MC3A2.D4.5
+-enable=MC3A2.D4.8
+-enable=MC3A2.D4.11
+-enable=MC3A2.D4.12
+-enable=MC3A2.D4.14
+-enable=MC3A2.D4.7
+-enable=MC3A2.R10.5
+-enable=MC3A2.R10.2
+-enable=MC3A2.R10.6
+-enable=MC3A2.R10.7
+-enable=MC3A2.R10.8
+-enable=MC3A2.R1.2
+-enable=MC3A2.R1.3
+-enable=MC3A2.R12.4
+-enable=MC3A2.R12.5
+-enable=MC3A2.R12.2
+-enable=MC3A2.R13.4
+-enable=MC3A2.R13.1
+-enable=MC3A2.R13.2
+-enable=MC3A2.R13.5
+-enable=MC3A2.R13.6
+-enable=MC3A2.R18.5
+-enable=MC3A2.R18.1
+-enable=MC3A2.R18.2
+-enable=MC3A2.R18.3
+-enable=MC3A2.R18.6
+-enable=MC3A2.R18.8
+-enable=MC3A2.R21.11
+-enable=MC3A2.R21.13
+-enable=MC3A2.R21.17
+-enable=MC3A2.R21.18
+-enable=MC3A2.R21.19
+-enable=MC3A2.R21.20
+-enable=MC3A2.R2.7
+-enable=MC3A2.R2.2
+-enable=MC3A2.R4.2
+-enable=MC3A2.R4.1
+-enable=MC3A2.R17.3
+-enable=MC3A2.R17.4
+-enable=MC3A2.R17.6
+-enable=MC3A2.R17.1
+-enable=MC3A2.R17.5
+-enable=MC3A2.R19.1
+-enable=MC3A2.R22.2
+-enable=MC3A2.R22.5
+-enable=MC3A2.R22.6
+-enable=MC3A2.R9.1
+-enable=MC3A2.R9.2
+-enable=MC3A2.R9.3
+-enable=MC3A2.R9.4
+-enable=MC3A2.R9.5
+-enable=MC3A2.D2.1
+-enable=MC3A2.R11.2
+-enable=MC3A2.R11.6
+-enable=MC3A2.R11.7
+-enable=MC3A2.R11.8
+-enable=MC3A2.R11.9
+-enable=MC3A2.R14.1
+-enable=MC3A2.R14.2
+-enable=MC3A2.R14.3
+-enable=MC3A2.R15.2
+-enable=MC3A2.R15.3
+-enable=MC3A2.R15.6
+-enable=MC3A2.R15.7
+-enable=MC3A2.R16.1
+-enable=MC3A2.R16.2
+-enable=MC3A2.R16.3
+-enable=MC3A2.R16.4
+-enable=MC3A2.R16.5
+-enable=MC3A2.R16.6
+-enable=MC3A2.R16.7
+-enable=MC3A2.R20.11
+-enable=MC3A2.R20.12
+-enable=MC3A2.R20.13
+-enable=MC3A2.R20.14
+-enable=MC3A2.R20.2
+-enable=MC3A2.R20.3
+-enable=MC3A2.R20.4
+-enable=MC3A2.R20.8
+-enable=MC3A2.R20.9
+-enable=MC3A2.R3.1
+-enable=MC3A2.R3.2
+-enable=MC3A2.R5.2
+-enable=MC3A2.R5.3
+-enable=MC3A2.R5.4
+-enable=MC3A2.R5.5
+-enable=MC3A2.R6.1
+-enable=MC3A2.R6.2
+-enable=MC3A2.R7.1
+-enable=MC3A2.R7.2
+-enable=MC3A2.R7.3
+-enable=MC3A2.R7.4
+-enable=MC3A2.R8.1
+-enable=MC3A2.R8.10
+-enable=MC3A2.R8.12
+-enable=MC3A2.R8.14
+-enable=MC3A2.R8.2
+-enable=MC3A2.R8.4
+-enable=MC3A2.R8.8
 -doc_end

cmake/sca/eclair/ECL/analysis_WP.ecl

@@ -10,23 +10,23 @@
 
 -doc_begin="Selection of guidelines from
 https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html"
--enable=MC3R1.R2.3
--enable=MC3R1.R2.1
--enable=MC3R1.R5.9
--enable=MC3R1.R5.1
--enable=MC3R1.R5.6
--enable=MC3R1.R5.7
--enable=MC3R1.R5.8
--enable=MC3R1.R8.9
--enable=MC3R1.R8.3
--enable=MC3R1.R8.5
--enable=MC3R1.R8.6
--enable=MC3R1.R22.4
--enable=MC3R1.R22.3
--enable=MC3R1.D1.1
--enable=MC3R1.D3.1
--enable=MC3R1.D4.1
--enable=MC3R1.D4.10
--enable=MC3R1.R17.2
--enable=MC3R1.R17.7
+-enable=MC3A2.R2.3
+-enable=MC3A2.R2.1
+-enable=MC3A2.R5.9
+-enable=MC3A2.R5.1
+-enable=MC3A2.R5.6
+-enable=MC3A2.R5.7
+-enable=MC3A2.R5.8
+-enable=MC3A2.R8.9
+-enable=MC3A2.R8.3
+-enable=MC3A2.R8.5
+-enable=MC3A2.R8.6
+-enable=MC3A2.R22.4
+-enable=MC3A2.R22.3
+-enable=MC3A2.D1.1
+-enable=MC3A2.D3.1
+-enable=MC3A2.D4.1
+-enable=MC3A2.D4.10
+-enable=MC3A2.R17.2
+-enable=MC3A2.R17.7
 -doc_end

cmake/sca/eclair/ECL/analysis_first_analysis.ecl

@@ -10,12 +10,12 @@
 
 -doc_begin="Selection of guidelines from
 https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html"
--enable=MC3R1.R8.2
--enable=MC3R1.R10.2
--enable=MC3R1.R10.5
--enable=MC3R1.R10.6
--enable=MC3R1.R11.2
--enable=MC3R1.R12.4
--enable=MC3R1.R13.4
--enable=MC3R1.R16.1
+-enable=MC3A2.R8.2
+-enable=MC3A2.R10.2
+-enable=MC3A2.R10.5
+-enable=MC3A2.R10.6
+-enable=MC3A2.R11.2
+-enable=MC3A2.R12.4
+-enable=MC3A2.R13.4
+-enable=MC3A2.R16.1
 -doc_end

cmake/sca/eclair/ECL/analysis_heavy_STU.ecl

@@ -10,14 +10,14 @@
 
 -doc_begin="Selection of guidelines from
 https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html"
--enable=MC3R1.D4.6
--enable=MC3R1.D4.9
--enable=MC3R1.R12.1
--enable=MC3R1.R13.3
--enable=MC3R1.R2.6
--enable=MC3R1.R10.1
--enable=MC3R1.R10.3
--enable=MC3R1.R10.4
--enable=MC3R1.R14.4
--enable=MC3R1.R20.7
+-enable=MC3A2.D4.6
+-enable=MC3A2.D4.9
+-enable=MC3A2.R12.1
+-enable=MC3A2.R13.3
+-enable=MC3A2.R2.6
+-enable=MC3A2.R10.1
+-enable=MC3A2.R10.3
+-enable=MC3A2.R10.4
+-enable=MC3A2.R14.4
+-enable=MC3A2.R20.7
 -doc_end

cmake/sca/eclair/ECL/analysis_std_lib.ecl

@@ -9,20 +9,20 @@
 
 -doc_begin="Selection of guidelines from
 https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html"
--enable=MC3R1.R21.1
--enable=MC3R1.R21.12
--enable=MC3R1.R21.14
--enable=MC3R1.R21.15
--enable=MC3R1.R21.16
--enable=MC3R1.R21.2
--enable=MC3R1.R21.3
--enable=MC3R1.R21.4
--enable=MC3R1.R21.6
--enable=MC3R1.R21.7
--enable=MC3R1.R21.9
--enable=MC3R1.R22.1
--enable=MC3R1.R22.10
--enable=MC3R1.R22.7
--enable=MC3R1.R22.8
--enable=MC3R1.R22.9
+-enable=MC3A2.R21.1
+-enable=MC3A2.R21.12
+-enable=MC3A2.R21.14
+-enable=MC3A2.R21.15
+-enable=MC3A2.R21.16
+-enable=MC3A2.R21.2
+-enable=MC3A2.R21.3
+-enable=MC3A2.R21.4
+-enable=MC3A2.R21.6
+-enable=MC3A2.R21.7
+-enable=MC3A2.R21.9
+-enable=MC3A2.R22.1
+-enable=MC3A2.R22.10
+-enable=MC3A2.R22.7
+-enable=MC3A2.R22.8
+-enable=MC3A2.R22.9
 -doc_end