drivers: gpio: wch: simplify port_toggle_bits logic

kartben · kartben · commit 6176b2ca1bef · 2025-06-21T15:31:27.000+02:00
computation of BSHR was unnecessarily complex, with redundant
XOR/masking operations.

Signed-off-by: Benjamin Cabé &lt;benjamin@zephyrproject.org&gt;
diff --git a/drivers/gpio/wch_gpio_ch32v00x.c b/drivers/gpio/wch_gpio_ch32v00x.c
@@ -104,9 +104,9 @@ static int gpio_ch32v00x_port_clear_bits_raw(const struct device *dev, uint32_t
 static int gpio_ch32v00x_port_toggle_bits(const struct device *dev, uint32_t pins)
 {
 	const struct gpio_ch32v00x_config *config = dev->config;
-	uint32_t changed = (config->regs->OUTDR ^ pins) & pins;
+	uint32_t current = config->regs->OUTDR;
 
-	config->regs->BSHR = (changed & pins) | (~changed & pins) << 16;
+	config->regs->BSHR = (~current & pins) | (current & pins) << 16;
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -104,9 +104,9 @@ static int gpio_ch32v00x_port_clear_bits_raw(const struct device *dev, uint32_t`
`104`	`104`	`static int gpio_ch32v00x_port_toggle_bits(const struct device *dev, uint32_t pins)`
`105`	`105`	`{`
`106`	`106`	`const struct gpio_ch32v00x_config *config = dev->config;`
`107`		`- uint32_t changed = (config->regs->OUTDR ^ pins) & pins;`
	`107`	`+ uint32_t current = config->regs->OUTDR;`
`108`	`108`
`109`		`- config->regs->BSHR = (changed & pins) \| (~changed & pins) << 16;`
	`109`	`+ config->regs->BSHR = (~current & pins) \| (current & pins) << 16;`
`110`	`110`
`111`	`111`	`return 0;`
`112`	`112`	`}`