Skip to content

Commit 562891a

Browse files
trunghieulenxpngphibang
authored andcommitted
drivers: video: ov5640: Fix HUE register write
SDE_CTRL8_REG's value must be modified using modify_register. Signed-off-by: Trung Hieu Le <trunghieu.le@nxp.com> Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
1 parent 3023c51 commit 562891a

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

drivers/video/ov5640.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -934,9 +934,13 @@ static int ov5640_set_ctrl_hue(const struct device *dev, int value)
934934
sign = 0x02;
935935
}
936936

937-
struct ov5640_reg hue_params[] = {{SDE_CTRL8_REG, sign},
938-
{SDE_CTRL1_REG, abs(cos_coef)},
939-
{SDE_CTRL2_REG, abs(sin_coef)}};
937+
struct ov5640_reg hue_params[] = {{SDE_CTRL1_REG, abs(cos_coef) & 0xFF},
938+
{SDE_CTRL2_REG, abs(sin_coef) & 0xFF}};
939+
940+
ret = ov5640_modify_reg(&cfg->i2c, SDE_CTRL8_REG, 0x7F, sign);
941+
if (ret) {
942+
return ret;
943+
}
940944

941945
return ov5640_write_multi_regs(&cfg->i2c, hue_params, ARRAY_SIZE(hue_params));
942946
}

0 commit comments

Comments
 (0)