Skip to content

Commit 501b95f

Browse files
Thalleyfabiobaltieri
authored andcommitted
Bluetooth: CSIP: Rename BT_CSIP_SET_MEMBER_NOTIFIABLE
Renamed BT_CSIP_SET_MEMBER_NOTIFIABLE to BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE to be more specific. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
1 parent 2bc963b commit 501b95f

File tree

6 files changed

+15
-9
lines changed

6 files changed

+15
-9
lines changed

doc/connectivity/bluetooth/shell/audio/cap.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ Setting a new SIRK
4040

4141
This command can modify the currently used SIRK. To get the new RSI to advertise on air,
4242
:code:`bt adv-data` or :code:`bt advertise` must be called again to set the new advertising data.
43-
If :code:`CONFIG_BT_CSIP_SET_MEMBER_NOTIFIABLE` is enabled, this will also notify connected
43+
If :code:`CONFIG_BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE` is enabled, this will also notify connected
4444
clients.
4545

4646
.. code-block:: console

doc/connectivity/bluetooth/shell/audio/csip.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ Setting a new SIRK
171171

172172
This command can modify the currently used SIRK. To get the new RSI to advertise on air,
173173
:code:`bt adv-data` or :code:`bt advertise` must be called again to set the new advertising data.
174-
If :code:`CONFIG_BT_CSIP_SET_MEMBER_NOTIFIABLE` is enabled, this will also notify connected
174+
If :code:`CONFIG_BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE` is enabled, this will also notify connected
175175
clients.
176176

177177
.. code-block:: console

doc/releases/migration-guide-4.2.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,12 @@ Timer
117117
Bluetooth
118118
*********
119119

120+
Bluetooth Audio
121+
===============
122+
123+
* ``CONFIG_BT_CSIP_SET_MEMBER_NOTIFIABLE`` has been renamed to
124+
:kconfig:option:`CONFIG_BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE``. (:github:`86763``)
125+
120126
Bluetooth Host
121127
==============
122128

subsys/bluetooth/audio/Kconfig.csip

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ config BT_CSIP_SET_MEMBER_MAX_INSTANCE_COUNT
4848
Enabling BT_CAP_ACCEPTOR_SET_MEMBER will take one of the allocated
4949
instances.
5050

51-
config BT_CSIP_SET_MEMBER_NOTIFIABLE
51+
config BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE
5252
bool "SIRK notifiable Support"
5353
help
5454
This option enables support for clients to be notified on SIRK changes.

subsys/bluetooth/audio/csip_set_member.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -285,12 +285,12 @@ static ssize_t read_sirk(struct bt_conn *conn, const struct bt_gatt_attr *attr,
285285
sirk, sizeof(*sirk));
286286
}
287287

288-
#if defined(CONFIG_BT_CSIP_SET_MEMBER_NOTIFIABLE)
288+
#if defined(CONFIG_BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE)
289289
static void sirk_cfg_changed(const struct bt_gatt_attr *attr, uint16_t value)
290290
{
291291
LOG_DBG("value 0x%04x", value);
292292
}
293-
#endif /* CONFIG_BT_CSIP_SET_MEMBER_NOTIFIABLE */
293+
#endif /* CONFIG_BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE */
294294

295295
static ssize_t read_set_size(struct bt_conn *conn,
296296
const struct bt_gatt_attr *attr,
@@ -614,7 +614,7 @@ static struct bt_conn_auth_info_cb auth_callbacks = {
614614
.bond_deleted = csip_bond_deleted
615615
};
616616

617-
#if defined(CONFIG_BT_CSIP_SET_MEMBER_NOTIFIABLE)
617+
#if defined(CONFIG_BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE)
618618
#define BT_CSIS_CHR_SIRK(_csip) \
619619
BT_AUDIO_CHRC(BT_UUID_CSIS_SIRK, BT_GATT_CHRC_READ | BT_GATT_CHRC_NOTIFY, \
620620
BT_GATT_PERM_READ_ENCRYPT, read_sirk, NULL, &_csip), \
@@ -623,7 +623,7 @@ static struct bt_conn_auth_info_cb auth_callbacks = {
623623
#define BT_CSIS_CHR_SIRK(_csip) \
624624
BT_AUDIO_CHRC(BT_UUID_CSIS_SIRK, BT_GATT_CHRC_READ, BT_GATT_PERM_READ_ENCRYPT, read_sirk, \
625625
NULL, &_csip)
626-
#endif /* CONFIG_BT_CSIP_SET_MEMBER_NOTIFIABLE */
626+
#endif /* CONFIG_BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE */
627627

628628
#define BT_CSIP_SERVICE_DEFINITION(_csip) {\
629629
BT_GATT_PRIMARY_SERVICE(BT_UUID_CSIS), \
@@ -769,7 +769,7 @@ static void notify_cb(struct bt_conn *conn, void *data)
769769
sizeof(svc_inst->set_lock));
770770
}
771771

772-
if (IS_ENABLED(CONFIG_BT_CSIP_SET_MEMBER_NOTIFIABLE) &&
772+
if (IS_ENABLED(CONFIG_BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE) &&
773773
atomic_test_and_clear_bit(client->flags, FLAG_NOTIFY_SIRK)) {
774774
notify(svc_inst, conn, BT_UUID_CSIS_SIRK, &svc_inst->sirk,
775775
sizeof(svc_inst->sirk));

tests/bsim/bluetooth/audio/prj.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ CONFIG_BT_MICP_MIC_CTLR_MAX_AICS_INST=2
8888
# Coordinated Set Identification
8989
CONFIG_BT_CSIP_SET_MEMBER=y
9090
CONFIG_BT_CSIP_SET_MEMBER_TEST_SAMPLE_DATA=y
91-
CONFIG_BT_CSIP_SET_MEMBER_NOTIFIABLE=y
91+
CONFIG_BT_CSIP_SET_MEMBER_SIRK_NOTIFIABLE=y
9292
CONFIG_BT_CSIP_SET_COORDINATOR=y
9393
CONFIG_BT_CSIP_SET_COORDINATOR_TEST_SAMPLE_DATA=y
9494

0 commit comments

Comments
 (0)