Skip to content

Commit 4bd1d39

Browse files
krish2718danieldegrasse
authored andcommitted
wifi: nrf70: Fix system work queue stack size override
Defaults cannot be overidden (even with configdefault extension), they only work if the original symbol is defined after the override e.g., "drivers and then subsys/net" but for kernel symbols,the default value overrides don't work due "kernel and drivers" order, the kernel defines the original symbol with the default and then it cannot be overridden. Move the kernel symbol override to the original definition to make it affect. Else any sample that uses nRF70 but doesn't enable WPA supplicant ends up with 1024 and crashes. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
1 parent 54573e2 commit 4bd1d39

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

drivers/wifi/nrf_wifi/Kconfig.nrfwifi

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -599,10 +599,8 @@ endif
599599

600600
if NETWORKING
601601
# Finetune defaults for certain system components used by the driver
602-
603-
config SYSTEM_WORKQUEUE_STACK_SIZE
604-
default 4096
605-
602+
# Note: These will take effect only if the symbol is not defined already
603+
# (i.e., the original symbol is processed after "drivers/Kconfig")
606604
config NET_TX_STACK_SIZE
607605
default 4096
608606

kernel/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,7 @@ config WORKQUEUE_WORK_TIMEOUT
585585
menu "System Work Queue Options"
586586
config SYSTEM_WORKQUEUE_STACK_SIZE
587587
int "System workqueue stack size"
588-
default 4096 if COVERAGE_GCOV
588+
default 4096 if COVERAGE_GCOV || WIFI_NRF70
589589
default 2560 if WIFI_NM_WPA_SUPPLICANT
590590
default 1024
591591

0 commit comments

Comments
 (0)