drivers: rtc: fix warning return value may be uninitialized

jasperjonker · jasperjonker · commit 45c6d8dc0545 · 2025-06-16T11:13:18.000+02:00
Fix the return value may be uninitialized on the RTC DS3231

Signed-off-by: Jasper &lt;jjasper.jonker@gmail.com&gt;
diff --git a/drivers/rtc/rtc_ds3231.c b/drivers/rtc/rtc_ds3231.c
@@ -59,7 +59,7 @@ struct rtc_ds3231_conf {
 static int rtc_ds3231_modify_register(const struct device *dev, uint8_t reg, uint8_t *buf,
 				      const uint8_t bitmask)
 {
-	int err;
+	int err = 0;
 	const struct rtc_ds3231_conf *config = dev->config;
 
 	if (bitmask != 255) {
@@ -77,8 +77,7 @@ static int rtc_ds3231_modify_register(const struct device *dev, uint8_t reg, uin
 	if (err != 0) {
 		return err;
 	}
-	err = mfd_ds3231_i2c_set_registers(config->mfd, reg, buf, 1);
-	return err;
+	return mfd_ds3231_i2c_set_registers(config->mfd, reg, buf, 1);
 }
 
 enum rtc_ds3231_freq {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ struct rtc_ds3231_conf {`
`59`	`59`	`static int rtc_ds3231_modify_register(const struct device dev, uint8_t reg, uint8_t buf,`
`60`	`60`	`const uint8_t bitmask)`
`61`	`61`	`{`
`62`		`- int err;`
	`62`	`+ int err = 0;`
`63`	`63`	`const struct rtc_ds3231_conf *config = dev->config;`
`64`	`64`
`65`	`65`	`if (bitmask != 255) {`
`@@ -77,8 +77,7 @@ static int rtc_ds3231_modify_register(const struct device *dev, uint8_t reg, uin`
`77`	`77`	`if (err != 0) {`
`78`	`78`	`return err;`
`79`	`79`	`}`
`80`		`- err = mfd_ds3231_i2c_set_registers(config->mfd, reg, buf, 1);`
`81`		`- return err;`
	`80`	`+ return mfd_ds3231_i2c_set_registers(config->mfd, reg, buf, 1);`
`82`	`81`	`}`
`83`	`82`
`84`	`83`	`enum rtc_ds3231_freq {`