Skip to content

Commit 4011ff6

Browse files
committed
samples: drivers: video: capture: logging improvements
Remove trailing spaces at the end of log string. Move arguments on the next line for readability. Align arguments to first line. Signed-off-by: Josuah Demangeon <me@josuah.net>
1 parent acea295 commit 4011ff6

File tree

1 file changed

+14
-14
lines changed
  • samples/drivers/video/capture/src

1 file changed

+14
-14
lines changed

samples/drivers/video/capture/src/main.c

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ static inline int display_setup(const struct device *const display_dev, const ui
3737

3838
LOG_INF("- Capabilities:");
3939
LOG_INF(" x_resolution = %u, y_resolution = %u, supported_pixel_formats = %u"
40-
" current_pixel_format = %u, current_orientation = %u",
41-
capabilities.x_resolution, capabilities.y_resolution,
42-
capabilities.supported_pixel_formats, capabilities.current_pixel_format,
43-
capabilities.current_orientation);
40+
" current_pixel_format = %u, current_orientation = %u",
41+
capabilities.x_resolution, capabilities.y_resolution,
42+
capabilities.supported_pixel_formats, capabilities.current_pixel_format,
43+
capabilities.current_orientation);
4444

4545
/* Set display pixel format to match the one in use by the camera */
4646
switch (pixfmt) {
@@ -131,9 +131,9 @@ int main(void)
131131
const struct video_format_cap *fcap = &caps.format_caps[i];
132132
/* fourcc to string */
133133
LOG_INF(" %s width [%u; %u; %u] height [%u; %u; %u]",
134-
VIDEO_FOURCC_TO_STR(fcap->pixelformat),
135-
fcap->width_min, fcap->width_max, fcap->width_step,
136-
fcap->height_min, fcap->height_max, fcap->height_step);
134+
VIDEO_FOURCC_TO_STR(fcap->pixelformat),
135+
fcap->width_min, fcap->width_max, fcap->width_step,
136+
fcap->height_min, fcap->height_max, fcap->height_step);
137137
i++;
138138
}
139139

@@ -167,20 +167,20 @@ int main(void)
167167

168168
if (!video_get_frmival(video_dev, &frmival)) {
169169
LOG_INF("- Default frame rate : %f fps",
170-
1.0 * frmival.denominator / frmival.numerator);
170+
1.0 * frmival.denominator / frmival.numerator);
171171
}
172172

173173
LOG_INF("- Supported frame intervals for the default format:");
174174
memset(&fie, 0, sizeof(fie));
175175
fie.format = &fmt;
176176
while (video_enum_frmival(video_dev, &fie) == 0) {
177177
if (fie.type == VIDEO_FRMIVAL_TYPE_DISCRETE) {
178-
LOG_INF(" %u/%u ", fie.discrete.numerator, fie.discrete.denominator);
178+
LOG_INF(" %u/%u", fie.discrete.numerator, fie.discrete.denominator);
179179
} else {
180180
LOG_INF(" [min = %u/%u; max = %u/%u; step = %u/%u]",
181-
fie.stepwise.min.numerator, fie.stepwise.min.denominator,
182-
fie.stepwise.max.numerator, fie.stepwise.max.denominator,
183-
fie.stepwise.step.numerator, fie.stepwise.step.denominator);
181+
fie.stepwise.min.numerator, fie.stepwise.min.denominator,
182+
fie.stepwise.max.numerator, fie.stepwise.max.denominator,
183+
fie.stepwise.step.numerator, fie.stepwise.step.denominator);
184184
}
185185
fie.index++;
186186
}
@@ -263,8 +263,8 @@ int main(void)
263263

264264
vbuf->type = type;
265265

266-
LOG_DBG("Got frame %u! size: %u; timestamp %u ms", frame++, vbuf->bytesused,
267-
vbuf->timestamp);
266+
LOG_DBG("Got frame %u! size: %u; timestamp %u ms",
267+
frame++, vbuf->bytesused, vbuf->timestamp);
268268

269269
#ifdef CONFIG_TEST
270270
if (is_colorbar_ok(vbuf->buffer, fmt)) {

0 commit comments

Comments
 (0)