Skip to content

Commit 3e1e2ea

Browse files
jukkarmmahadevan108
authored andcommitted
net: wifi: mgmt: Use memcpy instead of strncpy
Using strncpy gives this warning warning: 'strncpy' output may be truncated copying 32 bytes from a string of length 32 [-Wstringop-truncation] strncpy(roaming_params.neighbor_rep.neighbor_ap[idx].bssid_info, bssid_info, sizeof(roaming_params.neighbor_rep.neighbor_ap->bssid_info)); There is '\0' at the end of the allocated buffer so we can safely use memcpy() here to avoid any warnings. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
1 parent 0a75809 commit 3e1e2ea

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

subsys/net/l2/wifi/wifi_mgmt.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -535,14 +535,15 @@ void wifi_mgmt_raise_neighbor_rep_recv_event(struct net_if *iface, char *inbuf,
535535
}
536536
}
537537
if (!match && (roaming_params.neighbor_rep.neighbor_cnt < MAX_NEIGHBOR_AP_LIMIT)) {
538-
strncpy((char *)roaming_params.neighbor_rep.neighbor_ap[idx].bssid,
539-
bssid, sizeof(roaming_params.neighbor_rep.neighbor_ap[idx].bssid));
538+
memcpy((char *)roaming_params.neighbor_rep.neighbor_ap[idx].bssid,
539+
bssid,
540+
sizeof(roaming_params.neighbor_rep.neighbor_ap[idx].bssid));
540541
len = strnlen(bssid, sizeof(bssid) - 1);
541542
roaming_params.neighbor_rep.neighbor_ap[idx].bssid[len] = (uint8_t)'\0';
542543

543-
strncpy((char *)roaming_params.neighbor_rep.neighbor_ap[idx].bssid_info,
544-
(bssid_info),
545-
sizeof(roaming_params.neighbor_rep.neighbor_ap->bssid_info));
544+
memcpy((char *)roaming_params.neighbor_rep.neighbor_ap[idx].bssid_info,
545+
bssid_info,
546+
sizeof(roaming_params.neighbor_rep.neighbor_ap[idx].bssid_info));
546547
len = strnlen(bssid_info, sizeof(bssid_info) - 1);
547548
roaming_params.neighbor_rep.neighbor_ap[idx].bssid_info[len] =
548549
(uint8_t)'\0';

0 commit comments

Comments
 (0)