Skip to content

Commit 36661dc

Browse files
hasheddankartben
authored andcommitted
mgmt: mcumgr: transport: remove dup LoRaWAN smp_reassembly_init
The LoRaWAN SMP transport uses MCUMGR_TRANSPORT_LORAWAN_REASSEMBLY to enable reassembly. It selects MCUMGR_TRANSPORT_REASSEMBLY, which causes smp_transport_init to call smp_reassembly_init on the passed transport. This makes the subsequent call to smp_reassembly_init in the LoRaWAN transport initialization redundant. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
1 parent d7bf4b3 commit 36661dc

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

subsys/mgmt/mcumgr/transport/src/smp_lorawan.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,10 +249,6 @@ static void smp_lorawan_start(void)
249249
LOG_ERR("Failed to init LoRaWAN MCUmgr SMP transport: %d", rc);
250250
}
251251

252-
#ifdef CONFIG_MCUMGR_TRANSPORT_LORAWAN_REASSEMBLY
253-
smp_reassembly_init(&smp_lorawan_transport);
254-
#endif
255-
256252
#ifdef CONFIG_MCUMGR_TRANSPORT_LORAWAN_POLL_FOR_DATA
257253
k_thread_create(&smp_lorawan_thread, smp_lorawan_stack,
258254
K_KERNEL_STACK_SIZEOF(smp_lorawan_stack),

0 commit comments

Comments
 (0)