Skip to content

Commit 357434e

Browse files
sudarsan-22kartben
authored andcommitted
drivers: usb_c: fusb307: Check return value gpio_add_callback()
The result of gpio_add_callback() was not checked, which may lead to silent failure in alert interrupt setup. CID: 525074 Signed-off-by: sudarsan N <sudarsansamy2002@gmail.com>
1 parent 1793934 commit 357434e

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/usb_c/tcpc/fusb307.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -676,7 +676,12 @@ void fusb307_init_work_cb(struct k_work *work)
676676
gpio_pin_configure_dt(&cfg->alert_gpio, GPIO_INPUT);
677677

678678
gpio_init_callback(&data->alert_cb, fusb307_alert_cb, BIT(cfg->alert_gpio.pin));
679-
gpio_add_callback(cfg->alert_gpio.port, &data->alert_cb);
679+
ret = gpio_add_callback(cfg->alert_gpio.port, &data->alert_cb);
680+
if (ret < 0) {
681+
LOG_ERR("Failed to add GPIO callback: %d", ret);
682+
return;
683+
}
684+
680685
gpio_pin_interrupt_configure_dt(&cfg->alert_gpio, GPIO_INT_EDGE_TO_ACTIVE);
681686

682687
tcpci_init_alert_mask(data->dev);

0 commit comments

Comments
 (0)