Skip to content

Commit 21a0a80

Browse files
committed
drivers: rtc: fix warning return value may be uninitialized
Fix the return value may be uninitialized on the RTC DS3231 Signed-off-by: Jasper Jonker <jjasper.jonker@gmail.com>
1 parent 6c68584 commit 21a0a80

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

drivers/rtc/rtc_ds3231.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,11 @@ struct rtc_ds3231_conf {
5959
static int rtc_ds3231_modify_register(const struct device *dev, uint8_t reg, uint8_t *buf,
6060
const uint8_t bitmask)
6161
{
62-
int err;
6362
const struct rtc_ds3231_conf *config = dev->config;
6463

6564
if (bitmask != 255) {
6665
uint8_t og_buf = 0;
67-
68-
err = mfd_ds3231_i2c_get_registers(config->mfd, reg, &og_buf, 1);
66+
int err = mfd_ds3231_i2c_get_registers(config->mfd, reg, &og_buf, 1);
6967
if (err != 0) {
7068
return err;
7169
}
@@ -74,11 +72,8 @@ static int rtc_ds3231_modify_register(const struct device *dev, uint8_t reg, uin
7472
og_buf |= *buf;
7573
*buf = og_buf;
7674
}
77-
if (err != 0) {
78-
return err;
79-
}
80-
err = mfd_ds3231_i2c_set_registers(config->mfd, reg, buf, 1);
81-
return err;
75+
76+
return mfd_ds3231_i2c_set_registers(config->mfd, reg, buf, 1);
8277
}
8378

8479
enum rtc_ds3231_freq {

0 commit comments

Comments
 (0)