drivers: sensor: paj7620: fix return value of paj7620_get_hw_id()

kartben · dkalowsk · commit 1b93ce7226c1 · 2025-06-24T20:13:57.000-10:00
Use a local signed variable to store negative return values instead of
unsigned previously so that errors are actually detected/returned.

Signed-off-by: Benjamin Cabé &lt;benjamin@zephyrproject.org&gt;
diff --git a/drivers/sensor/pixart/paj7620/paj7620.c b/drivers/sensor/pixart/paj7620/paj7620.c
@@ -48,7 +48,7 @@ static int paj7620_select_register_bank(const struct device *dev, enum paj7620_m
 
 static int paj7620_get_hw_id(const struct device *dev, uint16_t *result)
 {
-	uint8_t ret;
+	int ret;
 	uint8_t hw_id[2];
 	const struct paj7620_config *config = dev->config;
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ static int paj7620_select_register_bank(const struct device *dev, enum paj7620_m`
`48`	`48`
`49`	`49`	`static int paj7620_get_hw_id(const struct device dev, uint16_t result)`
`50`	`50`	`{`
`51`		`- uint8_t ret;`
	`51`	`+ int ret;`
`52`	`52`	`uint8_t hw_id[2];`
`53`	`53`	`const struct paj7620_config *config = dev->config;`
`54`	`54`