Skip to content

Commit 10bb71e

Browse files
aunsbjergkartben
authored andcommitted
drivers: fuel_gauge: fix integer comparison in api functions
In the fuel_gauge_get_props and fuel_gauge_set_props functions, an array len is passed as a size_t but compared against an int, which leads to C++ compiler warnings when using -Werror=sign-compare. The fix is to use a size_t for the loop counter. Signed-off-by: Mikkel Jakobsen <mikkel.aunsbjerg@escolifesciences.com>
1 parent be5d44e commit 10bb71e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/zephyr/drivers/fuel_gauge.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ static inline int z_impl_fuel_gauge_get_props(const struct device *dev,
296296
{
297297
const struct fuel_gauge_driver_api *api = dev->api;
298298

299-
for (int i = 0; i < len; i++) {
299+
for (size_t i = 0; i < len; i++) {
300300
int ret = api->get_property(dev, props[i], vals + i);
301301

302302
if (ret) {
@@ -349,7 +349,7 @@ static inline int z_impl_fuel_gauge_set_props(const struct device *dev,
349349
fuel_gauge_prop_t *props,
350350
union fuel_gauge_prop_val *vals, size_t len)
351351
{
352-
for (int i = 0; i < len; i++) {
352+
for (size_t i = 0; i < len; i++) {
353353
int ret = fuel_gauge_set_prop(dev, props[i], vals[i]);
354354

355355
if (ret) {

0 commit comments

Comments
 (0)