drivers: video: stm32-dcmi: Drop video_stm32_dcmi_is_fmt_valid

Drop video_stm32_dcmi_is_fmt_valid() as it is not needed. In this
function, (i) checking against a format based on another utility
function video_bits_per_pixel() is not robust, this check is done in
the sensor driver, (ii) checking against the heap size is not
appropriate because this should be done when allocating buffers, not
in get/set format.

Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>

Author: ngphibang

drivers/video/video_stm32_dcmi.c

@@ -186,28 +186,12 @@ static int stm32_dcmi_enable_clock(const struct device *dev)
 	return clock_control_on(dcmi_clock, (clock_control_subsys_t *)&config->pclken);
 }
 
-static inline int video_stm32_dcmi_is_fmt_valid(uint32_t pixelformat, uint32_t pitch,
-						uint32_t height)
-{
-	if (video_bits_per_pixel(pixelformat) / BITS_PER_BYTE == 0 ||
-	    pitch * height > CONFIG_VIDEO_BUFFER_POOL_SZ_MAX) {
-		return -EINVAL;
-	}
-
-	return 0;
-}
-
 static int video_stm32_dcmi_set_fmt(const struct device *dev, struct video_format *fmt)
 {
 	const struct video_stm32_dcmi_config *config = dev->config;
 	struct video_stm32_dcmi_data *data = dev->data;
 	int ret;
 
-	ret = video_stm32_dcmi_is_fmt_valid(fmt->pixelformat, fmt->pitch, fmt->height);
-	if (ret < 0) {
-		return ret;
-	}
-
 	ret = video_set_format(config->sensor_dev, fmt);
 	if (ret < 0) {
 		return ret;
@@ -234,11 +218,6 @@ static int video_stm32_dcmi_get_fmt(const struct device *dev, struct video_forma
 		return ret;
 	}
 
-	ret = video_stm32_dcmi_is_fmt_valid(fmt->pixelformat, fmt->pitch, fmt->height);
-	if (ret < 0) {
-		return ret;
-	}
-
 	data->fmt = *fmt;
 
 	return 0;
@@ -342,12 +321,6 @@ static int video_stm32_dcmi_enum_frmival(const struct device *dev, struct video_
 	const struct video_stm32_dcmi_config *config = dev->config;
 	int ret;
 
-	ret = video_stm32_dcmi_is_fmt_valid(fie->format->pixelformat, fie->format->pitch,
-					    fie->format->height);
-	if (ret < 0) {
-		return ret;
-	}
-
 	ret = video_enum_frmival(config->sensor_dev, fie);
 	if (ret < 0) {
 		return ret;