Fix Event API. Update demos. Update tests (#793)

Author: obetomuniz

demo/constructor-node.html

@@ -20,11 +20,15 @@
       var clipboard = new ClipboardJS(btn);
 
       clipboard.on('success', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
 
       clipboard.on('error', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
     </script>
   </body>

demo/constructor-nodelist.html

@@ -20,11 +20,15 @@
       var clipboard = new ClipboardJS(btns);
 
       clipboard.on('success', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
 
       clipboard.on('error', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
     </script>
   </body>

demo/constructor-selector.html

@@ -19,11 +19,15 @@
       var clipboard = new ClipboardJS('.btn');
 
       clipboard.on('success', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
 
       clipboard.on('error', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
     </script>
   </body>

demo/function-target.html

@@ -22,11 +22,15 @@
       });
 
       clipboard.on('success', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
 
       clipboard.on('error', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
     </script>
   </body>

demo/function-text.html

@@ -21,11 +21,15 @@
       });
 
       clipboard.on('success', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
 
       clipboard.on('error', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
     </script>
   </body>

demo/target-div.html

@@ -24,11 +24,15 @@
       var clipboard = new ClipboardJS('.btn');
 
       clipboard.on('success', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
 
       clipboard.on('error', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
     </script>
   </body>

demo/target-input.html

@@ -24,7 +24,9 @@
       var clipboard = new ClipboardJS('.btn');
 
       clipboard.on('success', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
 
       clipboard.on('error', function (e) {

demo/target-textarea.html

@@ -24,11 +24,15 @@
       var clipboard = new ClipboardJS('.btn');
 
       clipboard.on('success', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
 
       clipboard.on('error', function (e) {
-        console.log(e);
+        console.info('Action:', e.action);
+        console.info('Text:', e.text);
+        console.info('Trigger:', e.trigger);
       });
     </script>
   </body>

dist/clipboard.js

@@ -287,16 +287,17 @@ var Clipboard = /*#__PURE__*/function (_Emitter) {
     key: "onClick",
     value: function onClick(e) {
       var trigger = e.delegateTarget || e.currentTarget;
-      var selectedText = actions_default({
-        action: this.action(trigger),
+      var action = this.action(trigger) || 'copy';
+      var text = actions_default({
+        action: action,
         container: this.container,
         target: this.target(trigger),
         text: this.text(trigger)
       }); // Fires an event based on the copy operation result.
 
-      this.emit(selectedText ? 'success' : 'error', {
-        action: this.action,
-        text: selectedText,
+      this.emit(text ? 'success' : 'error', {
+        action: action,
+        text: text,
         trigger: trigger,
         clearSelection: function clearSelection() {
           if (trigger) {

dist/clipboard.min.js

@@ -69,17 +69,18 @@ class Clipboard extends Emitter {
    */
   onClick(e) {
     const trigger = e.delegateTarget || e.currentTarget;
-    const selectedText = ClipboardActionDefault({
-      action: this.action(trigger),
+    const action = this.action(trigger) || 'copy';
+    const text = ClipboardActionDefault({
+      action,
       container: this.container,
       target: this.target(trigger),
       text: this.text(trigger),
     });
 
     // Fires an event based on the copy operation result.
-    this.emit(selectedText ? 'success' : 'error', {
-      action: this.action,
-      text: selectedText,
+    this.emit(text ? 'success' : 'error', {
+      action,
+      text,
       trigger,
       clearSelection() {
         if (trigger) {

src/clipboard.js

@@ -158,6 +158,7 @@ describe('Clipboard', () => {
 
       clipboard.on('success', (e) => {
         assert.property(e, 'action');
+        assert.equal(e.action, 'copy');
         assert.property(e, 'text');
         assert.property(e, 'trigger');
         assert.property(e, 'clearSelection');