✨ disable answer email notification if the answerer is the asker (#238)

hgwood · Errorname · commit ccd755828da7 · 2019-10-15T23:22:12.000+02:00
diff --git a/server/src/resolvers/answer.js b/server/src/resolvers/answer.js
@@ -31,10 +31,18 @@ module.exports = {
           `
         {
           id
+          user {
+            id
+          }
           node {
             flags(where:{type:"unanswered"}) {
               id
             }
+            question {
+              user {
+                id
+              }
+            }
           }
         }
         `
@@ -67,7 +75,12 @@ module.exports = {
       })
 
       algolia.updateNode(ctx, nodeId)
-      mailgun.sendNewAnswer(ctx, nodeId)
+
+      // Let's notify the user who asked the question, but only if they did not answer the
+      // question them-selves.
+      if (answer.node.question.user.id !== answer.user.id) {
+        mailgun.sendNewAnswer(ctx, nodeId)
+      }
 
       return ctx.prisma.query.answer(
         {

Original file line number	Diff line number	Diff line change
`@@ -31,10 +31,18 @@ module.exports = {`
`31`	`31`	`
`32`	`32`	`{`
`33`	`33`	`id`
	`34`	`+ user {`
	`35`	`+ id`
	`36`	`+ }`
`34`	`37`	`node {`
`35`	`38`	`flags(where:{type:"unanswered"}) {`
`36`	`39`	`id`
`37`	`40`	`}`
	`41`	`+ question {`
	`42`	`+ user {`
	`43`	`+ id`
	`44`	`+ }`
	`45`	`+ }`
`38`	`46`	`}`
`39`	`47`	`}`
`40`	`48`	`
`@@ -67,7 +75,12 @@ module.exports = {`
`67`	`75`	`})`
`68`	`76`
`69`	`77`	`algolia.updateNode(ctx, nodeId)`
`70`		`- mailgun.sendNewAnswer(ctx, nodeId)`
	`78`	`+`
	`79`	`+ // Let's notify the user who asked the question, but only if they did not answer the`
	`80`	`+ // question them-selves.`
	`81`	`+ if (answer.node.question.user.id !== answer.user.id) {`
	`82`	`+ mailgun.sendNewAnswer(ctx, nodeId)`
	`83`	`+ }`
`71`	`84`
`72`	`85`	`return ctx.prisma.query.answer(`
`73`	`86`	`{`