Skip to content

Commit 5a550fe

Browse files
thibaudbraultThibaud Brault
andauthored
🐛 remove circular dependency for some helpers (#350)
Co-authored-by: Thibaud Brault <thibaud.brault@zenika.com>
1 parent 6f1e93f commit 5a550fe

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

server/src/helpers/index.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,8 @@ const {
66
refreshCertifiedFlag
77
} = require('./certified')
88
const diffTags = require('./diffTags')
9-
const emojify = require('./emojify')
109
const history = require('./history')
1110
const randomString = require('./randomString')
12-
const requireText = require('./requireText')
1311
const {
1412
createFlagAndUpdateHistoryAndAlgolia,
1513
deleteFlagAndUpdateHistoryAndAlgolia
@@ -25,10 +23,8 @@ module.exports = {
2523
deleteCertifedFlagIfNoLongerApplicable,
2624
refreshCertifiedFlag,
2725
diffTags,
28-
emojify,
2926
history,
3027
randomString,
31-
requireText,
3228
slugify,
3329
createFlagAndUpdateHistoryAndAlgolia,
3430
deleteFlagAndUpdateHistoryAndAlgolia,

server/src/integrations/mailgun/answer/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
const mjml2html = require('mjml')
22
const Converter = require('showdown').Converter
33
const XSSFilter = require('showdown-xss-filter')
4-
const { requireText, emojify } = require('../../../helpers')
4+
const requireText = require('../../../helpers/requireText')
5+
const emojify = require('../../../helpers/emojify')
56

67
const answer = {
78
generateHtml: variables => mjml2html(requireText('./answer.mjml', require, variables)).html,

server/src/integrations/slack.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const fetch = require('isomorphic-fetch')
22

33
const algolia = require('./algolia')
44

5-
const { emojify } = require('../helpers')
5+
const emojify = require('../helpers/emojify')
66

77
// TMP_TAGS
88

0 commit comments

Comments
 (0)