Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 2529382

Browse files
committed
add changelog
1 parent 8719cc4 commit 2529382

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ Versions prior to 0.4.0 were released as the package "weierophinney/hal".
2424

2525
### Fixed
2626

27-
- Nothing.
27+
- [#36](https://github.com/zendframework/zend-expressive-hal/pull/36)
28+
Fixes lost parameter queries in collection output.
2829

2930
## 1.0.0 - 2018-03-15
3031

src/ResourceGenerator/UrlBasedCollectionStrategy.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ protected function generateLinkForPage(
7171
) : Link {
7272
$paginationParam = $metadata->getPaginationParam();
7373
$paginationType = $metadata->getPaginationParamType();
74-
$url = $metadata->getUrl() . '?' . http_build_query($request->getQueryParams());;
74+
$url = $metadata->getUrl() . '?' . http_build_query($request->getQueryParams());
7575

7676
switch ($paginationType) {
7777
case Metadata\AbstractCollectionMetadata::TYPE_PLACEHOLDER:
@@ -104,7 +104,7 @@ protected function generateSelfLink(
104104

105105
$queryStringArgs = $request->getQueryParams();
106106
$url = $metadata->getUrl();
107-
if($queryStringArgs !== null) {
107+
if ($queryStringArgs !== null) {
108108
$url .= '?' . http_build_query($queryStringArgs);
109109
}
110110

0 commit comments

Comments
 (0)