Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 17af450

Browse files
committed
PSR-15 support (http-interop/http-server-middleware)
1 parent d997148 commit 17af450

File tree

4 files changed

+95
-37
lines changed

4 files changed

+95
-37
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
},
2222
"require": {
2323
"php": "^7.1",
24-
"http-interop/http-middleware": "^0.4.1",
24+
"http-interop/http-server-middleware": "^1.0.1",
2525
"psr/container": "^1.0",
2626
"psr/http-message": "^1.0.1"
2727
},

composer.lock

Lines changed: 79 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/AuthenticationMiddleware.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@
77

88
namespace Zend\Expressive\Authentication;
99

10-
use Interop\Http\ServerMiddleware\DelegateInterface;
11-
use Interop\Http\ServerMiddleware\MiddlewareInterface as ServerMiddlewareInterface;
10+
use Interop\Http\Server\MiddlewareInterface;
11+
use Interop\Http\Server\RequestHandlerInterface;
12+
use Psr\Http\Message\ResponseInterface;
1213
use Psr\Http\Message\ServerRequestInterface;
1314

14-
class AuthenticationMiddleware implements ServerMiddlewareInterface
15+
class AuthenticationMiddleware implements MiddlewareInterface
1516
{
1617
/**
1718
* @var AuthenticationInterface
@@ -26,11 +27,11 @@ public function __construct(AuthenticationInterface $auth)
2627
/**
2728
* {@inheritDoc}
2829
*/
29-
public function process(ServerRequestInterface $request, DelegateInterface $delegate)
30+
public function process(ServerRequestInterface $request, RequestHandlerInterface $handler) : ResponseInterface
3031
{
3132
$user = $this->auth->authenticate($request);
3233
if (null !== $user) {
33-
return $delegate->process($request->withAttribute(UserInterface::class, $user));
34+
return $handler->handle($request->withAttribute(UserInterface::class, $user));
3435
}
3536
return $this->auth->unauthorizedResponse($request);
3637
}

test/AuthenticationMiddlewareTest.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
*/
77
namespace ZendTest\Expressive\Authentication;
88

9-
use Interop\Http\ServerMiddleware\DelegateInterface;
10-
use Interop\Http\ServerMiddleware\MiddlewareInterface as ServerMiddlewareInterface;
9+
use Interop\Http\Server\MiddlewareInterface;
10+
use Interop\Http\Server\RequestHandlerInterface;
1111
use PHPUnit\Framework\TestCase;
1212
use Psr\Http\Message\ResponseInterface;
1313
use Psr\Http\Message\ServerRequestInterface;
@@ -25,14 +25,14 @@ public function setUp()
2525
$this->authentication = $this->prophesize(AuthenticationInterface::class);
2626
$this->request = $this->prophesize(ServerRequestInterface::class);
2727
$this->authenticatedUser = $this->prophesize(UserInterface::class);
28-
$this->delegate = $this->prophesize(DelegateInterface::class);
28+
$this->handler = $this->prophesize(RequestHandlerInterface::class);
2929
}
3030

3131
public function testConstructor()
3232
{
3333
$middleware = new AuthenticationMiddleware($this->authentication->reveal());
3434
$this->assertInstanceOf(AuthenticationMiddleware::class, $middleware);
35-
$this->assertInstanceOf(ServerMiddlewareInterface::class, $middleware);
35+
$this->assertInstanceOf(MiddlewareInterface::class, $middleware);
3636
}
3737

3838
public function testProcessWithNoAuthenticatedUser()
@@ -45,7 +45,7 @@ public function testProcessWithNoAuthenticatedUser()
4545
->willReturn($response->reveal());
4646

4747
$middleware = new AuthenticationMiddleware($this->authentication->reveal());
48-
$result = $middleware->process($this->request->reveal(), $this->delegate->reveal());
48+
$result = $middleware->process($this->request->reveal(), $this->handler->reveal());
4949

5050
$this->assertInstanceOf(ResponseInterface::class, $result);
5151
$this->assertEquals($response->reveal(), $result);
@@ -60,14 +60,14 @@ public function testProcessWithAuthenticatedUser()
6060
->willReturn($this->request->reveal());
6161
$this->authentication->authenticate($this->request->reveal())
6262
->willReturn($this->authenticatedUser->reveal());
63-
$this->delegate->process($this->request->reveal())
64-
->willReturn($response->reveal());
63+
$this->handler->handle($this->request->reveal())
64+
->willReturn($response->reveal());
6565

6666
$middleware = new AuthenticationMiddleware($this->authentication->reveal());
67-
$result = $middleware->process($this->request->reveal(), $this->delegate->reveal());
67+
$result = $middleware->process($this->request->reveal(), $this->handler->reveal());
6868

6969
$this->assertInstanceOf(ResponseInterface::class, $result);
7070
$this->assertEquals($response->reveal(), $result);
71-
$this->delegate->process($this->request->reveal())->shouldBeCalled();
71+
$this->handler->handle($this->request->reveal())->shouldBeCalled();
7272
}
7373
}

0 commit comments

Comments
 (0)