From 2a3e7700d13665fdcd87a9d764c271d980e4ddc5 Mon Sep 17 00:00:00 2001 From: Aurelie Verrot Date: Mon, 9 Jun 2025 12:42:55 +0200 Subject: [PATCH 1/3] add l10n team as codeowners of translation files --- .github/CODEOWNERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index fd2d3a36..949c53a4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1,2 @@ -* @zendesk/wattle +* @zendesk/wattle +config/locales/* @zendesk/localization From aacb18e1a8b0fea52a49781a282f2478e5f88bd2 Mon Sep 17 00:00:00 2001 From: Aurelie Verrot Date: Mon, 9 Jun 2025 12:45:55 +0200 Subject: [PATCH 2/3] add i18n validations in CI --- .github/workflows/actions.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml index 39dbf6fa..48082199 100644 --- a/.github/workflows/actions.yml +++ b/.github/workflows/actions.yml @@ -35,6 +35,23 @@ jobs: - name: lint run: bundle exec rubocop + i18n: + name: I18n + runs-on: [ self-hosted, zendesk-stable ] + env: + ARTIFACTORY_API_KEY: ${{ secrets.ARTIFACTORY_API_KEY }} + ARTIFACTORY_USERNAME: ${{ secrets.ARTIFACTORY_USERNAME }} + BUNDLE_ZDREPO__JFROG__IO: "${{ secrets.BUNDLE_ZDREPO__JFROG__IO }}" + steps: + - uses: actions/checkout@v4 + - uses: zendesk/setup-ruby@v1 + with: + ruby-version: 3.4 + - name: Validate + run: | + gem install zendesk_i18n_dev_tools --source https://$BUNDLE_ZDREPO__JFROG__IO@zdrepo.jfrog.io/zdrepo/api/gems/gems-local/ + validate_string_sweep_files config/locales/translations/zendesk_apps_support.yml + tests_successful: name: Tests passing? needs: tests From a0f21057884abe865e7e8f456265243a6959d626 Mon Sep 17 00:00:00 2001 From: Aurelie Verrot Date: Mon, 9 Jun 2025 12:47:42 +0200 Subject: [PATCH 3/3] change runner --- .github/workflows/actions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml index 48082199..498deaeb 100644 --- a/.github/workflows/actions.yml +++ b/.github/workflows/actions.yml @@ -37,7 +37,7 @@ jobs: i18n: name: I18n - runs-on: [ self-hosted, zendesk-stable ] + runs-on: ubuntu-latest env: ARTIFACTORY_API_KEY: ${{ secrets.ARTIFACTORY_API_KEY }} ARTIFACTORY_USERNAME: ${{ secrets.ARTIFACTORY_USERNAME }}