From 6e6a4210b682dbd7e8df5911634ddf186f73ba59 Mon Sep 17 00:00:00 2001
From: Tristan Vu <tristan.vu@zendesk.com>
Date: Wed, 14 May 2025 16:40:38 -0400
Subject: [PATCH 1/3] chore(zendesk-api-service): update return type

---
 src/models/zendesk-api.ts           | 13 +++++++++----
 src/services/zendesk-api-service.ts |  6 +++---
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/src/models/zendesk-api.ts b/src/models/zendesk-api.ts
index 97fa907..9f0b72f 100644
--- a/src/models/zendesk-api.ts
+++ b/src/models/zendesk-api.ts
@@ -58,12 +58,17 @@ export interface ILinesResults extends IZendeskResponse {
     lines: Line[];
 }
 
-export interface LineBase {
+enum LineType {
+    Digital = "digital",
+    Phone = "phone"
+}
+
+interface LineBase {
     id: number;
     nickname: string;
     priority: number;
     default_group_id: number | null;
-    line_type: string;
+    line_type: LineType;
     transcription: boolean;
     recorded: boolean;
     call_recording_consent: string;
@@ -76,14 +81,14 @@ export interface LineBase {
 }
 
 export interface DigitalLine extends LineBase {
-    line_type: "digital";
+    line_type: LineType.Digital;
     brand_id: number;
     line_id: string;
     outbound_number: string | null;
 }
 
 export interface PhoneLine extends LineBase {
-    line_type: "phone";
+    line_type: LineType.Phone;
     country_code: string;
     external: boolean;
     // eslint-disable-next-line id-denylist
diff --git a/src/services/zendesk-api-service.ts b/src/services/zendesk-api-service.ts
index 11655aa..2467caf 100644
--- a/src/services/zendesk-api-service.ts
+++ b/src/services/zendesk-api-service.ts
@@ -21,7 +21,7 @@ import {
     IZendeskOrganizations,
     ILinesResults,
     IZendeskResponse,
-    LineBase
+    Line
 } from "@models/index";
 import { convertContentMessageToHtml } from "@utils/convert-content-message-to-html";
 import { getFromClient } from "@utils/get-from-client";
@@ -259,8 +259,8 @@ export class ZendeskApiService {
     /**
      * Fetch all voice lines
      */
-    public async getVoiceLines(fetchAllLines = true): Promise<LineBase[]> {
-        return this.fetchAllPaginatedResults<ILinesResults, LineBase>(
+    public async getVoiceLines(fetchAllLines = true): Promise<Line[]> {
+        return this.fetchAllPaginatedResults<ILinesResults, Line>(
             `/api/v2/channels/voice/lines`,
             fetchAllLines,
             (response) => response.lines

From 7ad5971dff2e868e91866344620930c569081ed5 Mon Sep 17 00:00:00 2001
From: Tristan Vu <tristan.vu@zendesk.com>
Date: Wed, 14 May 2025 16:46:57 -0400
Subject: [PATCH 2/3] chore(zendesk api): remove enum

---
 src/models/zendesk-api.ts | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/models/zendesk-api.ts b/src/models/zendesk-api.ts
index 9f0b72f..b43b5f6 100644
--- a/src/models/zendesk-api.ts
+++ b/src/models/zendesk-api.ts
@@ -58,17 +58,12 @@ export interface ILinesResults extends IZendeskResponse {
     lines: Line[];
 }
 
-enum LineType {
-    Digital = "digital",
-    Phone = "phone"
-}
-
 interface LineBase {
     id: number;
     nickname: string;
     priority: number;
     default_group_id: number | null;
-    line_type: LineType;
+    line_type: "phone" | "digital";
     transcription: boolean;
     recorded: boolean;
     call_recording_consent: string;
@@ -81,14 +76,14 @@ interface LineBase {
 }
 
 export interface DigitalLine extends LineBase {
-    line_type: LineType.Digital;
+    line_type: "digital";
     brand_id: number;
     line_id: string;
     outbound_number: string | null;
 }
 
 export interface PhoneLine extends LineBase {
-    line_type: LineType.Phone;
+    line_type: "phone";
     country_code: string;
     external: boolean;
     // eslint-disable-next-line id-denylist

From 0090f7a4513907bda230fd8f872230ad33490b06 Mon Sep 17 00:00:00 2001
From: tristan-vu <tristan-vu@users.noreply.github.com>
Date: Wed, 14 May 2025 20:53:18 +0000
Subject: [PATCH 3/3] [BOT] Bump version from 0.3.0 to 0.3.1

---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 23edcd0..2ddbbe6 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@zendesk/zaf-toolbox",
-    "version": "0.3.0",
+    "version": "0.3.1",
     "description": "A toolbox for ZAF application built with 🩷 by Zendesk Labs",
     "main": "lib/src/index.js",
     "types": "lib/src/index.d.ts",