unwrap crash when running via Waypipe

[tliron]

Summary

Trying to run zed over waypipe, e.g.:

waypipe ssh myhost /usr/bin/zed --foreground

And get this error:

thread 'main' panicked at crates/gpui/src/platform/linux/wayland/client.rs:150:51:
called `Result::unwrap()` on an `Err` value: UnsupportedVersion
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It seems to me that we should at least get a proper error instead of using unwrap. Maybe use except instead? :)

But also ... why won't it work over waypipe?

waypipe 0.9.1, features: lz4 zstd dmabuf video vaapi

Zed Version and System Specs

Zed: v0.196.6 (Zed)
OS: Linux Wayland fedora 42
Memory: 251.4 GiB
Architecture: x86_64
GPU: AMD Radeon RX 6500 XT (RADV NAVI24) || radv || Mesa 25.1.4

[tmke8]

But also ... why won't it work over waypipe?

It seems waypipe is using version 6 of the xdg_wm_base protocol: https://gitlab.freedesktop.org/mstoeckl/waypipe/-/blob/master/protocols/xdg-shell.xml#L32 but zed only supports up to version 5:

zed/crates/gpui/src/platform/linux/wayland/client.rs

Line 150 in 9353ba7

wm_base: globals.bind(&qh, 2..=5, ()).unwrap(),

[tliron]

Hm, I see that someone converted this into a "discussion". Support for Waypipe may be up for discussion, but I would argue that the use of unwrap here is a bug. We don't want users to see a panic just because they have the wrong version of Wayland. This needs to be a proper error message with an explanation.