Setting to allow .editorconfig take control over soft-wrap

[katry0]

Summary

Since #20198 PR is merged, it is not possible to have .editorconfig property max_line_length set overwrite zed preferred_line_length and soft_wrap setting which was obviously purpose of PR but there are people (including me), who want to use max_line_length exactly that way - specially the ruler not set on max_line_length can be confusing.

I know it is non-standard feature, so I suggest create new boolean setting editorconfig_soft_wrap by default set on false, that allows .editorconfig to overwrite zed preferred_line_length and soft_wrap setting.

In other words, Zed had a (miss-)feature, that allowed .editorconfig to set editor ruler and take control over soft-wrap, which was useful for some users. This feature was completely removed because it was non-standard, but non-standard does not mean it can`t be useful for someone, and better solution would be disabling it by default and keep possibility to use it.

Zed Version and System Specs

Zed: v0.175.6 (Zed)
OS: Linux Wayland arch unknown
Memory: 61.5 GiB
Architecture: x86_64
GPU: AMD Radeon 780M (RADV GFX1103_R1) || radv || Mesa 24.3.4-arch1.1

[katry0]

There is pull request (closed for now) which was linked to issue, but since issue was "converted" into discussion it is not linked anymore: #25889

@notpeter I still think this is more "issue" than something we need to discuss - zed had functionality that allowed .editorconfig soft-wrap and set ruler, which was removed. I think it is okay to disable that functionality by default, but why to remove it completely? There are obviously people using it that way (after all, for some reason it was originally implemented that way).

[notpeter]

It is not clear to me from the description what this issue is actually about:

it is not possible to have .editorconfig property max_line_length set overwrite zed preferred_line_length and soft_wrap setting which was obviously purpose of PR but there are people (including me), who want to use max_line_length exactly that way - specially the ruler not set on max_line_length can be confusing.

Is this actually a bug or a feature request (or a regression). Perhaps with a clearer description with multiple sentences (feel free to edit!) it would be possible to discuss possible options for addressing it (or whether it's a behavior we definitely want / definitely want to change).

At first glance, a new top-level settings key to change the behavior for how an .editorconfig will override other settings seems like a bad solution for what might be a niche problem. In general, adding yet another top-level settings is a hint that this is probably not the right solution.

But instead you filed an issue 7minutes before opening your PR. While we appreciate the desire for members of the community contribute towards Zed's development, you've skipped past the part where you attempt to define the issue and jumped to the solutions/outrage that your PR wasn't merged. Please don't @ tag me -- just because you wrote a comment does not entitle you to spam my notifications.

[katry0]

Is this actually a bug or a feature request (or a regression). Perhaps with a clearer description with multiple sentences (feel free to edit!) it would be possible to discuss possible options for addressing it (or whether it's a behavior we definitely want / definitely want to change).

It is feature (or maybe miss-feature, but used by some users), but feature Zed had and was removed and it is very frustrating when you are using feature that disappear by one update and you are not able to enable it again. But okay, I'll try to describe better what it's about for those who aren't affected.

At first glance, a new top-level settings key to change the behavior for how an .editorconfig will override other settings seems like a bad solution for what might be a niche problem. In general, adding yet another top-level settings is a hint that this is probably not the right solution.

I see there is aversion to creating new setting but why do not have settings section that describes .editorconfig behavior you prefer?

So instead of one key I proposed above:

{
    "editorconfig_soft_wrap": true
}

there would be a section:

{
    "editorconfig": {
        "allow_soft_wrap": true,
        "allow_set_ruler": true
    }
}

I don't see a better solution at the moment. Normally I would write an extension for this instead of integrating it into the editor (and skip all of this "hey is mine 15 line feature / fix good enough for maintainers?" pain) but that's not possible at the moment and won't be possible for a long time.

But instead you filed an issue 7minutes before opening your PR. While we appreciate the desire for members of the community contribute towards Zed's development, you've skipped past the part where you attempt to define the issue and jumped to the solutions/outrage that your PR wasn't merged. Please don't @ tag me -- just because you wrote a comment does not entitle you to spam my notifications.

Low timeframe between opening an issue and PR is not an valid argument IMO - almost whole code was implemented before and just removed, all I needed was a setting condition (and fix tests). If possible, it is best to propose a solution right away when creating an issue - it is ok that PR was closed, but should be mentioned.

About that tag - issue was converted into discussion without any comment, all I needed was reason this happened. If a comment was added along with the conversion, I wouldn't tag anyone.