On Air should support sub-apps created with NiceGUI's APIRouter

[xinetzone]

ui.run_with(
    app,
    mount_path='/', 
    storage_secret='',  
    on_air=True,
    # native=True,
)

see : main.py

ERROR:

Work:

• 

• 

[rodja]

It's working fine for me with this example:

from fastapi import FastAPI
from nicegui import ui

app = FastAPI()

@app.get('/api')
def read_root():
    return {'Hello': 'World'}

@ui.page('/')
def show():
    ui.label('Hello, FastAPI!')
    ui.button('click me', on_click=lambda: ui.notify('clicked'))
    ui.link('subpage', '/subpage')

@ui.page('/subpage')
def subpage():
    ui.label('Hello, subpage!')

ui.run_with(app,on_air=True)

Did you enter the url https://asia.on-air.io/test by yourself? Or how did you end up with that? There should always be a path like /devices/<id> which identifies your instance.

[xinetzone]

# main.py
from fastapi import FastAPI
from nicegui import ui, app as gui
from routers import test

gui.include_router(test.router)

app = FastAPI()

@app.get('/api')
def read_root():
    return {'Hello': 'World'}

@ui.page('/')
def show():
    ui.label('Hello, FastAPI!')
    ui.button('click me', on_click=lambda: ui.notify('clicked'))
    ui.link('subpage', '/subpage')
    ui.link("test", "/test")

@ui.page('/subpage')
def subpage():
    ui.label('Hello, subpage!')

ui.run_with(app, on_air=True)

[xinetzone]

[xinetzone]

# test.py
"""NiceGUI 文档"""
from pathlib import Path
from nicegui import ui, APIRouter

ROOT = Path(__file__).parent
router = APIRouter(prefix='/test')

@router.page('/')
def page():
    ui.label("测试")

[xinetzone]

[xinetzone]

This is an automatic redirect to https://asia.on-air.io/test.

[rodja]

Oh wow. I think we totally miss On Air support for APIRouter. Here a minimal reproduction:

from nicegui import APIRouter, app, ui

router = APIRouter(prefix='/router')
app.include_router(router)
ui.link('go to router', '/router')
ui.link('go to subpage', '/subpage')

@router.page('/')
def router_page():
    ui.label('Hello from APIRouter!')

@ui.page('/subpage')
def subpage():
    ui.label('Hello from subpage!')

ui.run(on_air=True)

Opening subpage works, but via APIRouter not. This is correctly marked as a feature request. I'll just update the title accordingly.

[rodja]

The issue seems to be related to Kludex/starlette#869 and Kludex/starlette#2514. When accessing /router/ it works, but /router results in a 307 redirect to the absolute url http://localhost/router/. I still can not understand why Starlette is doing such a thing. But be that as it may: in NiceGUI we can improve upon that. See pull request #5113.