From 26cdf8985f1058b546a1da583e90ae796b796a1d Mon Sep 17 00:00:00 2001 From: Davis Vann Bennett Date: Sat, 24 May 2025 14:19:05 +0200 Subject: [PATCH 1/2] use our fork of s3fs for upstream testing --- pyproject.toml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index f1c290e1b1..02102fbf56 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -210,7 +210,11 @@ dependencies = [ 'numpy', # from scientific-python-nightly-wheels 'numcodecs @ git+https://github.com/zarr-developers/numcodecs', 'fsspec @ git+https://github.com/fsspec/filesystem_spec', - 's3fs @ git+https://github.com/fsspec/s3fs', + # we use a fork of s3fs because fsspec/s3fs declares an exact version of fsspec, + # which cannot be satisfied when we use the git version of fsspec. + # our fork relaxes the upper bound on the fsspec dependency. + # see https://github.com/fsspec/s3fs/pull/966 + 's3fs @ git+https://github.com/zarr-developers/s3fs', 'universal_pathlib @ git+https://github.com/fsspec/universal_pathlib', 'typing_extensions @ git+https://github.com/python/typing_extensions', 'donfig @ git+https://github.com/pytroll/donfig', From 82c965a18ed27b5172d7c388c23eb7bedfa494c5 Mon Sep 17 00:00:00 2001 From: Davis Vann Bennett Date: Wed, 4 Jun 2025 15:04:44 +0200 Subject: [PATCH 2/2] lint --- tests/test_metadata/test_consolidated.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test_metadata/test_consolidated.py b/tests/test_metadata/test_consolidated.py index 9bf1c4e544..f71a946300 100644 --- a/tests/test_metadata/test_consolidated.py +++ b/tests/test_metadata/test_consolidated.py @@ -618,6 +618,7 @@ async def test_use_consolidated_for_children_members( expected = ["b", "b/c"] assert result == expected + @pytest.mark.parametrize("fill_value", [np.nan, np.inf, -np.inf]) async def test_consolidated_metadata_encodes_special_chars( memory_store: Store, zarr_format: ZarrFormat, fill_value: float