Rewinded due to time difference (race confitions)

[Osanosa]

Currently when I ff or seek on timeline I always get thrown back with "rewinded due to the time difference with"
this is very inconvenient

Potential solutions:

• add a few seconds grace period after a rewind to not sync to the server
• change locally cached server time to the new one

[yuroyami]

While II was checking out my implementation of the protocol (which I wrote almost 3 years ago), particularly the part that handles the States (which is the part responsible for syncing), I found out that my ignoreOnTheFly is literally half-implemented. The server updates are handled correctly but when the client performs an action, it will not notify the server that it performed an update and will be ignoring any events until the server acknowledges it.

I am supposed to be incrementing the client's ignoreOnTheFly with each active command so that server states are ignored until they're acknowledged. I believe it's directly related to what you're experiencing. I need to do some major rewriting to the whole "JsonHandler" as well, and make use of Kotlinx Serialization's casting to data classes (via @Serializable) instead of extracting values from each JSON field manually. The code looks cluttered this way and very hard to extend or maintain.

[Osanosa]

there could be added a simpler workaround temporary
maybe for example keep a timestamp of the last playtime change and wrap rewinding with if block?

[yuroyami]

@Osanosa
That would be nice as a second-layer safeguard but I am not sure if this will cause other issues such as ignoring states that are sent by other users. We can go down that route only if the ignoreOnTheFly implementation fails to safeguard against this. We'll see

[Osanosa]

well i think that 3s delay would allow enough time to send data to the server, but after that time it would just sync

one other solution might be to check for current rewind jobs, for example if a recent sending data to server was not finished skip syncing

[Osanosa]

i mean a simple if else wrap should be easier if you say there are major rewrites needed

[Osanosa]

currently for me to consistently change time the only reliable way is to mash play/pause button, spamming with requests so it would override server rewrites

[yuroyami]

i mean a simple if else wrap should be easier if you say there are major rewrites needed

We can implement this safeguard as a temporary workaround as you said, I will keep it in mind

[RaXorX]

@yuroyami Potentially related to this as well. #25
I wonder how much would those controls actually contribute to the state handling unless that is entirely different to that.